Add Airflow 3 development readme by eladkal · Pull Request #41457 · apache/airflow

eladkal · 2024-08-14T06:29:53Z

Lets have a doc that list the protocols we accepted for development of Airflow 3

kaxil

One point of discussion is comments -- other than that lgtm

uranusjr · 2024-08-14T12:32:35Z

Also, since I just opened a backport PR (#41469)

Is it expected to not have CI run? Should at least some test jobs run?

potiuk · 2024-08-14T12:38:08Z

Also, since I just opened a backport PR (#41469)

Is it expected to not have CI run? Should at least some test jobs run?

#41474 -> PRs workflows were only enabled for main. It might need some more fixes, but let's merge it to main and close/reopen your PR to see if it will succeed.

jscheffl

Thanks for the documentation. Some clarifications and proposals in ordering, else from content I agree - therefore approve.

amoghrajesh

@eladkal this looks great, had a couple of comments and one qn.
BTW, should we also have a section that tells how to decide if a PR is supposed to go into AF3 or 2.10.x?

amoghrajesh

LGTM

kaxil · 2024-08-19T12:08:59Z

Pre-commit (doctoc) is failing

+- [Milestones for PR](#milestones-for-pr)
+  - [Set 2.10.x milestone](#set-210x-milestone)
+  - [Set 2.11 milestone](#set-211-milestone)
+  - [Set 3 milestone](#set-3-milestone)

jscheffl · 2024-08-19T16:16:35Z

Pre-commit (doctoc) is failing

+- [Milestones for PR](#milestones-for-pr)
+  - [Set 2.10.x milestone](#set-210x-milestone)
+  - [Set 2.11 milestone](#set-211-milestone)
+  - [Set 3 milestone](#set-3-milestone)

If we need to find more things that we need to take care as committer/PMS, we might really re-structure not from the role of contributor/committer but but it in the reversed order to describe per use case and have a checklist per PR what we should do? Will there be more things coming?

eladkal · 2024-08-19T16:30:36Z

If we need to find more things that we need to take care as committer/PMS, we might really re-structure not from the role of contributor/committer but but it in the reversed order to describe per use case and have a checklist per PR what we should do? Will there be more things coming?

We can always change the doc structure (even now if you have a suggestion to make it more friendly)
I assume we will add/remove stuff as we move forward. For example after 2.11 the 2.10 branch related stuff won't be needed.

hussein-awala

Good idea!

shahar1

Overall LGTM - my comments are mostly regarding proofreading and style (apologies in advance for nitpicking).
General suggestion - being consistent when referring to a single or multiple PRs.

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>

Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>

eladkal · 2024-09-11T18:19:18Z

Merging. We can iterate/change the doc as needed

* Add Airflow 3 development readme * fix typo * Update dev/README_AIRFLOW3_DEV.md Co-authored-by: Jarek Potiuk <jarek@potiuk.com> * restructure doc * fix static checks * updates * fixes * fix spell checks * clarify cherry picking * add milestones * fix doc * Update dev/README_AIRFLOW3_DEV.md Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com> * add 2.11 mental model * Update dev/README_AIRFLOW3_DEV.md Co-authored-by: Jarek Potiuk <jarek@potiuk.com> * fixes --------- Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>

eladkal requested review from ashb, jedcunningham and potiuk as code owners August 14, 2024 06:29

boring-cyborg Bot added the area:dev-tools label Aug 14, 2024

eladkal mentioned this pull request Aug 14, 2024

Deprecate implicit default DAG schedule #41321

Merged

eladkal requested review from kaxil, uranusjr and vikramkoka August 14, 2024 06:32

uranusjr reviewed Aug 14, 2024

View reviewed changes

Comment thread dev/README_AIRFLOW3_DEV.md Outdated

kaxil approved these changes Aug 14, 2024

View reviewed changes

potiuk reviewed Aug 14, 2024

View reviewed changes

Comment thread dev/README_AIRFLOW3_DEV.md Outdated

potiuk approved these changes Aug 14, 2024

View reviewed changes

jscheffl approved these changes Aug 14, 2024

View reviewed changes

Comment thread dev/README_AIRFLOW3_DEV.md Outdated

Comment thread dev/README_AIRFLOW3_DEV.md Outdated

Comment thread dev/README_AIRFLOW3_DEV.md Outdated

amoghrajesh reviewed Aug 15, 2024

View reviewed changes

Comment thread dev/README_AIRFLOW3_DEV.md Outdated

Comment thread dev/README_AIRFLOW3_DEV.md Outdated

Comment thread dev/README_AIRFLOW3_DEV.md Outdated

kaxil approved these changes Aug 15, 2024

View reviewed changes

amoghrajesh approved these changes Aug 16, 2024

View reviewed changes

potiuk reviewed Aug 18, 2024

View reviewed changes

Comment thread dev/README_AIRFLOW3_DEV.md Outdated

potiuk approved these changes Aug 19, 2024

View reviewed changes

jscheffl reviewed Aug 19, 2024

View reviewed changes

Comment thread dev/README_AIRFLOW3_DEV.md Outdated

jscheffl reviewed Aug 19, 2024

View reviewed changes

Comment thread dev/README_AIRFLOW3_DEV.md Outdated

ephraimbuddy reviewed Aug 19, 2024

View reviewed changes

Comment thread dev/README_AIRFLOW3_DEV.md Outdated

ephraimbuddy reviewed Aug 19, 2024

View reviewed changes

Comment thread dev/README_AIRFLOW3_DEV.md Outdated

ephraimbuddy reviewed Aug 19, 2024

View reviewed changes

Comment thread dev/README_AIRFLOW3_DEV.md Outdated

ephraimbuddy reviewed Aug 19, 2024

View reviewed changes

Comment thread dev/README_AIRFLOW3_DEV.md Outdated

ephraimbuddy reviewed Aug 19, 2024

View reviewed changes

Comment thread dev/README_AIRFLOW3_DEV.md Outdated

jscheffl reviewed Aug 21, 2024

View reviewed changes

Comment thread dev/README_AIRFLOW3_DEV.md Outdated

eladkal force-pushed the airflow3 branch from cac7419 to 67d6387 Compare August 22, 2024 13:26

hussein-awala approved these changes Aug 22, 2024

View reviewed changes

jscheffl reviewed Aug 22, 2024

View reviewed changes

Comment thread dev/README_AIRFLOW3_DEV.md Outdated

potiuk reviewed Aug 22, 2024

View reviewed changes

Comment thread dev/README_AIRFLOW3_DEV.md Outdated

potiuk mentioned this pull request Aug 22, 2024

Adding url sanitisation for extra links #41665

Merged

eladkal force-pushed the airflow3 branch from f0d83bf to 7cae1b3 Compare August 22, 2024 14:58

shahar1 reviewed Aug 23, 2024

View reviewed changes

eladkal and others added 15 commits September 9, 2024 19:58

Add Airflow 3 development readme

e9aedcc

fix typo

f5e1fd3

Update dev/README_AIRFLOW3_DEV.md

9d43c15

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>

restructure doc

abfd246

fix static checks

f83e235

updates

7b93d6c

fixes

d565ba2

fix spell checks

86131ff

clarify cherry picking

49ed5fb

add milestones

51c5939

fix doc

b1a427c

Update dev/README_AIRFLOW3_DEV.md

cbfd00b

Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>

add 2.11 mental model

014cac7

Update dev/README_AIRFLOW3_DEV.md

a461f7d

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>

fixes

dc270bc

eladkal force-pushed the airflow3 branch from 7cae1b3 to dc270bc Compare September 10, 2024 02:58

eladkal merged commit 25cc8b2 into apache:main Sep 11, 2024

eladkal deleted the airflow3 branch September 11, 2024 18:19

eladkal added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Sep 11, 2024

Conversation

eladkal commented Aug 14, 2024

Uh oh!

Uh oh!

kaxil left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

uranusjr commented Aug 14, 2024

Uh oh!

potiuk commented Aug 14, 2024

Uh oh!

jscheffl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

amoghrajesh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

amoghrajesh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kaxil commented Aug 19, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jscheffl commented Aug 19, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eladkal commented Aug 19, 2024

Uh oh!

Uh oh!

hussein-awala left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

shahar1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eladkal commented Sep 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants