Skip to content

Relocate airflow.auth to airflow.api_fastapi.auth#47492

Merged
ashb merged 1 commit into
mainfrom
move-auth-managers
Mar 7, 2025
Merged

Relocate airflow.auth to airflow.api_fastapi.auth#47492
ashb merged 1 commit into
mainfrom
move-auth-managers

Conversation

@ashb

@ashb ashb commented Mar 7, 2025

Copy link
Copy Markdown
Member

All of these pckages are related directly to the API server, so it makes sense
to limit the number of "second-level" packages we have under airflow package
to keep things smaller/more well structured.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Comment thread .pre-commit-config.yaml
pierrejeambrun
pierrejeambrun previously approved these changes Mar 7, 2025

@pierrejeambrun pierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just one minor adjustment I think.

Comment thread tests/auth/managers/simple/conftest.py
@pierrejeambrun pierrejeambrun dismissed their stale review March 7, 2025 12:28

CI not happy

@jscheffl jscheffl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep it moving!

@ashb ashb force-pushed the move-auth-managers branch from de547f0 to 0adaca9 Compare March 7, 2025 13:36
@potiuk

potiuk commented Mar 7, 2025

Copy link
Copy Markdown
Member

Just a breeze test to fix

@vincbeck vincbeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@ashb

ashb commented Mar 7, 2025

Copy link
Copy Markdown
Member Author

Sorry, making a bit of hash of this PR. 🤞🏻

@ashb

ashb commented Mar 7, 2025

Copy link
Copy Markdown
Member Author

sdfdsakf;jdsfkldsajfdsjk :table-flip:

@ashb ashb force-pushed the move-auth-managers branch 2 times, most recently from e5b5329 to d7d1cd4 Compare March 7, 2025 20:59
All of these pckages are related directly to the API server, so it makes sense
to limit the number of "second-level" packages we have under `airflow` package
to keep things smaller/more well structured.
@ashb ashb force-pushed the move-auth-managers branch from d7d1cd4 to c6f16fa Compare March 7, 2025 22:48
@ashb ashb merged commit 8cc9f1f into main Mar 7, 2025
@ashb ashb deleted the move-auth-managers branch March 7, 2025 23:40
ashb added a commit that referenced this pull request Mar 10, 2025
This was missed in #47492 as it is explicitly marked as a manual hook to run
ashb added a commit that referenced this pull request Mar 10, 2025
This was missed in #47492 as it is explicitly marked as a manual hook to run
ashb added a commit that referenced this pull request Mar 10, 2025
This was missed in #47492 as it is explicitly marked as a manual hook to run
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
This was missed in apache#47492 as it is explicitly marked as a manual hook to run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API area:dev-tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants