Skip to content

feat(AIP-84): add auth to /execution/assets endpoints #47658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Lee-W wants to merge 1 commit into from
Closed

feat(AIP-84): add auth to /execution/assets endpoints #47658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion airflow/api_fastapi/execution_api/routes/assets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,12 @@

from typing import Annotated

from fastapi import HTTPException, Query, status
from fastapi import Depends, HTTPException, Query, status
from sqlalchemy import select

from airflow.api_fastapi.common.db.common import SessionDep
from airflow.api_fastapi.common.router import AirflowRouter
from airflow.api_fastapi.core_api.security import requires_access_asset
from airflow.api_fastapi.execution_api.datamodels.asset import AssetResponse
from airflow.models.asset import AssetModel

Expand All @@ -33,6 +34,7 @@
status.HTTP_404_NOT_FOUND: {"description": "Asset not found"},
status.HTTP_401_UNAUTHORIZED: {"description": "Unauthorized"},
},
dependencies=[Depends(requires_access_asset("GET"))],
)


Expand Down
38 changes: 30 additions & 8 deletions tests/api_fastapi/execution_api/routes/test_assets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@


class TestGetAssetByName:
def test_get_asset_by_name(self, client, session):
def test_get_asset_by_name(self, test_client, session):
asset = AssetModel(
id=1,
name="test_get_asset_by_name",
Expand All @@ -44,7 +44,7 @@ def test_get_asset_by_name(self, client, session):
session.add_all([asset, asset_active])
session.commit()

response = client.get("/execution/assets/by-name", params={"name": "test_get_asset_by_name"})
response = test_client.get("/execution/assets/by-name", params={"name": "test_get_asset_by_name"})

assert response.status_code == 200
assert response.json() == {
Expand All @@ -58,8 +58,8 @@ def test_get_asset_by_name(self, client, session):
session.delete(asset_active)
session.commit()

def test_asset_name_not_found(self, client):
response = client.get("/execution/assets/by-name", params={"name": "non_existent"})
def test_asset_name_not_found(self, test_client):
response = test_client.get("/execution/assets/by-name", params={"name": "non_existent"})

assert response.status_code == 404
assert response.json() == {
Expand All @@ -69,9 +69,21 @@ def test_asset_name_not_found(self, client):
}
}

def test_get_config_should_response_401(self, unauthenticated_test_client):
response = unauthenticated_test_client.get(
"/execution/assets/by-name", params={"name": "test_get_asset_by_name"}
)
assert response.status_code == 401

def test_get_config_should_response_403(self, unauthorized_test_client):
response = unauthorized_test_client.get(
"/execution/assets/by-name", params={"name": "test_get_asset_by_name"}
)
assert response.status_code == 403


class TestGetAssetByUri:
def test_get_asset_by_uri(self, client, session):
def test_get_asset_by_uri(self, test_client, session):
asset = AssetModel(
name="test_get_asset_by_uri",
uri="s3://bucket/key",
Expand All @@ -84,7 +96,7 @@ def test_get_asset_by_uri(self, client, session):
session.add_all([asset, asset_active])
session.commit()

response = client.get("/execution/assets/by-uri", params={"uri": "s3://bucket/key"})
response = test_client.get("/execution/assets/by-uri", params={"uri": "s3://bucket/key"})

assert response.status_code == 200
assert response.json() == {
Expand All @@ -98,8 +110,8 @@ def test_get_asset_by_uri(self, client, session):
session.delete(asset_active)
session.commit()

def test_asset_uri_not_found(self, client):
response = client.get("/execution/assets/by-uri", params={"uri": "non_existent"})
def test_asset_uri_not_found(self, test_client):
response = test_client.get("/execution/assets/by-uri", params={"uri": "non_existent"})

assert response.status_code == 404
assert response.json() == {
Expand All @@ -108,3 +120,13 @@ def test_asset_uri_not_found(self, client):
"reason": "not_found",
}
}

def test_get_config_should_response_401(self, unauthenticated_test_client):
response = unauthenticated_test_client.get(
"/execution/assets/by-uri", params={"uri": "s3://bucket/key"}
)
assert response.status_code == 401

def test_get_config_should_response_403(self, unauthorized_test_client):
response = unauthorized_test_client.get("/execution/assets/by-uri", params={"uri": "s3://bucket/key"})
assert response.status_code == 403