Adds validation on backfill dryrun#47790
Merged
Merged
Conversation
Adds some date checks before triggering backfill dryrun
aritra24
requested review from
bbovenzi,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
bbovenzi
reviewed
Mar 14, 2025
bbovenzi
reviewed
Mar 14, 2025
bbovenzi
left a comment
bbovenzi
left a comment
Contributor
There was a problem hiding this comment.
While we're at it. Do you mind changing the alert for "X runs will be trigger"? Instead of choosing to render or not render, we should just change its visibility. Then the modal won't change size and flicker as the user adjusts params.
pierrejeambrun
left a comment
pierrejeambrun
left a comment
Member
There was a problem hiding this comment.
Looks good. Just a few suggestions
pierrejeambrun
approved these changes
Mar 17, 2025
bbovenzi
approved these changes
Mar 18, 2025
agupta01
pushed a commit
to agupta01/airflow
that referenced
this pull request
Mar 21, 2025
* Adds validation on backfill dryrun Adds some date checks before triggering backfill dryrun * Review comments handled * Update datetime check
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
* Adds validation on backfill dryrun Adds some date checks before triggering backfill dryrun * Review comments handled * Update datetime check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds some date checks before triggering backfill dryrun
Fixes: #47698
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.