Skip to content

Add mapping for deprecated default value for executor in core section#48800

Merged
phanikumv merged 1 commit into
apache:mainfrom
astronomer:add-config-for-update
Apr 4, 2025
Merged

Add mapping for deprecated default value for executor in core section#48800
phanikumv merged 1 commit into
apache:mainfrom
astronomer:add-config-for-update

Conversation

@sunank200

@sunank200 sunank200 commented Apr 4, 2025

Copy link
Copy Markdown
Collaborator

Currently, config setting AIRFLOW__CORE__EXECUTOR=SequentialExecutor in Airflow 3.0 causes issues without providing a proper error message. This PR does two changes:

  1. When AIRFLOW__CORE__EXECUTOR=SequentialExecutor is set, it now throws an appropriate error and updates the default executor to LocalExecutor within the validate() method of configuration.py.
  2. It also adds a mapping for the default value change for AIRFLOW__CORE__EXECUTOR in the airflow config update command. airflow config upgrade upgrades executor=SequentialExecutor to executor=LocalExecutor.

I tested it, and you can see that the yellow warning is now from configuration validation, while the rest of it is from the airflow config update as in the following screenshot:
Screenshot 2025-04-04 at 9 00 16 PM

airflow.cfg before:
Screenshot 2025-04-04 at 9 00 00 PM

After running airflow config update, airflow.cfg is change to:
Screenshot 2025-04-04 at 9 00 28 PM

closes: #48765


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@phanikumv phanikumv merged commit b5bed3b into apache:main Apr 4, 2025
@phanikumv phanikumv deleted the add-config-for-update branch April 4, 2025 16:06
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
diogotrodrigues pushed a commit to diogotrodrigues/airflow that referenced this pull request Apr 6, 2025
simonprydden pushed a commit to simonprydden/airflow that referenced this pull request Apr 8, 2025
@sunank200 sunank200 added the _eol_backport-to-v2-11-test Mark PR with this label to backport to v2-11-test branch label May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:CLI _eol_backport-to-v2-11-test Mark PR with this label to backport to v2-11-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configuring SequentialExecutor results in very non-obvious error

5 participants