Skip to content

Set execution api url in breeze config environment #49753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gopidesupavan merged 2 commits into from
Apr 24, 2025
Merged

Set execution api url in breeze config environment #49753

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5baedf
Set execution api url in breeze config environment
gopidesupavan Apr 24, 2025
e06ac01
Set execution api url from breeze shell params
gopidesupavan Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dev/breeze/src/airflow_breeze/params/shell_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,6 +523,7 @@ def env_variables_for_docker_commands(self) -> dict[str, str]:
_set_var(_env, "AIRFLOW__CELERY__BROKER_URL", self.airflow_celery_broker_url)
_set_var(_env, "AIRFLOW__CORE__AUTH_MANAGER", self.auth_manager_path)
_set_var(_env, "AIRFLOW__CORE__EXECUTOR", self.executor)
_set_var(_env, "AIRFLOW__CORE__EXECUTION_API_SERVER_URL", "http://localhost:8080/execution/")

@ashb ashb Apr 25, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we need to set this? This is the default

@ashb ashb Apr 25, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @kaxil

@gopidesupavan gopidesupavan Apr 25, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default is removed #49747 , and the default base_url doesn't have any value in https://github.com/apache/airflow/blob/main/airflow-core/src/airflow/config_templates/config.yml#L1294 ?

@gopidesupavan gopidesupavan Apr 25, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update default base_url with value?

@ashb ashb Apr 25, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No -- if we set base_url then all sorts of things with the webserver get trickier -- we removed it from there for a reason.

@kaxil Perhaps we need to tweak 49747 to use base_url if it's an absolute URL, but default to localhost:8080 if it's relative?

@kaxil kaxil Apr 25, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah

@kaxil kaxil Apr 25, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR: #49782

if self.auth_manager == SIMPLE_AUTH_MANAGER:
_set_var(_env, "AIRFLOW__CORE__SIMPLE_AUTH_MANAGER_USERS", "admin:admin,viewer:viewer")
_set_var(
Expand Down