Remove sqlalchemy-spanner exclusion after it's been yanked.#51433
Merged
Conversation
boring-cyborg
Bot
added
area:dev-tools
area:providers
provider:google
Member
Author
|
Follow up after #51393 |
amoghrajesh
reviewed
Jun 5, 2025
amoghrajesh
left a comment
amoghrajesh
left a comment
Contributor
There was a problem hiding this comment.
A comment which I will let you handle as per your thinking, looks good otherwise
vincbeck
reviewed
Jun 5, 2025
vincbeck
left a comment
vincbeck
left a comment
Contributor
There was a problem hiding this comment.
I also updated the doc when I added this constraint, we should revert that as well
potiuk
force-pushed
the
remove-sqlalchemy-spanner-exclusion
branch
from
e1e08c4 to
bfd8345
Compare
The broken sqlalchemy-spanner 1.12.0 has been yanked: googleapis/python-spanner-sqlalchemy#682 (comment)
potiuk
force-pushed
the
remove-sqlalchemy-spanner-exclusion
branch
from
bfd8345 to
40c1259
Compare
Member
Author
That is automatically updated at release time, but yeah - I removed it too. |
vincbeck
approved these changes
Jun 5, 2025
Contributor
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker ebde18e v3-0-testThis should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 5, 2025
…d. (apache#51433) The broken sqlalchemy-spanner 1.12.0 has been yanked: (cherry picked from commit ebde18e) Co-authored-by: Jarek Potiuk <jarek@potiuk.com> https: //github.com/googleapis/python-spanner-sqlalchemy/issues/682#issuecomment-2943731677
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 5, 2025
…d. (apache#51433) The broken sqlalchemy-spanner 1.12.0 has been yanked: (cherry picked from commit ebde18e) Co-authored-by: Jarek Potiuk <jarek@potiuk.com> https: //github.com/googleapis/python-spanner-sqlalchemy/issues/682#issuecomment-2943731677
potiuk
added a commit
that referenced
this pull request
Jun 5, 2025
…d. (#51433) (#51449) The broken sqlalchemy-spanner 1.12.0 has been yanked: (cherry picked from commit ebde18e) https: //github.com/googleapis/python-spanner-sqlalchemy/issues/682#issuecomment-2943731677
kaxil
pushed a commit
that referenced
this pull request
Jun 6, 2025
…d. (#51433) (#51449) The broken sqlalchemy-spanner 1.12.0 has been yanked: (cherry picked from commit ebde18e) https: //github.com/googleapis/python-spanner-sqlalchemy/issues/682#issuecomment-2943731677
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
…1433) The broken sqlalchemy-spanner 1.12.0 has been yanked: googleapis/python-spanner-sqlalchemy#682 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The broken sqlalchemy-spanner 1.12.0 has been yanked:
googleapis/python-spanner-sqlalchemy#682 (comment)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.