remove test_serde_serialize_recursion_limit to fix ci

[nailo2c]

Yesterday, a PR I submitted adding a unit test for the serialize-related function was merged. However, I'm not sure why this unit test fails in CI when running the following command: breeze testing core-tests --use-xdist --skip-db-tests --no-db-cleanup --backend none

For now, I'm removing this test, as I've noticed it is causing failures in several PRs.

Affected PRs:
#51701
#51735
#51698

[jscheffl]

Seems to be also related to failures in https://github.com/apache/airflow/actions/runs/15655403802/job/44105937266

[potiuk]

I am not sure if removing failed tests because it fails is a good idea.

[jscheffl]

I am not sure if removing failed tests because it fails is a good idea.

I as well... usually... but I am wonderuing how this test passed initially in https://github.com/apache/airflow/actions/runs/15639878625 and from then on failed on main.
So if it is a new and unstable test we should revert and properly re-implment.

We should not remove tests that are long standing.

[potiuk]

Likely because it was behind:

But I think we should in this case let the author - @nailo2c - can you take a look and check and retry it ?

[potiuk]

(BTW. @nailo2c -> noting bad -> it happens to every one of us :). I just don't like to reverse changes without a firm "I know why" and "there is a plan to fix it" :)

[nailo2c]

Got it, let me take a look on it, and thanks for the help! :)

[nailo2c]

It was likely caused by behind, I checked out a new branch from the latest main and the test passed again.

The logic of this unit test is quite simple, let me dig in and try to find out why his happened, then maybe submit another PR to add this test back?

Unit test:

def test_serde_serialize_recursion_limit(self):
    depth = sys.getrecursionlimit() - 1
    with pytest.raises(RecursionError, match="maximum recursion depth reached for serialization"):
        serialize(object(), depth=depth)

Tested function:

MAX_RECURSION_DEPTH = sys.getrecursionlimit() - 1
def serialize(o: object, depth: int = 0) -> U | None:
    if depth == MAX_RECURSION_DEPTH:
        raise RecursionError("maximum recursion depth reached for serialization")

[kaxil]

It was likely caused by behind, I checked out a new branch from the latest main and the test passed again.

The logic of this unit test is quite simple, let me dig in and try to find out why his happened, then maybe submit another PR to add this test back?

Unit test:

def test_serde_serialize_recursion_limit(self):
    depth = sys.getrecursionlimit() - 1
    with pytest.raises(RecursionError, match="maximum recursion depth reached for serialization"):
        serialize(object(), depth=depth)

Tested function:

MAX_RECURSION_DEPTH = sys.getrecursionlimit() - 1
def serialize(o: object, depth: int = 0) -> U | None:
    if depth == MAX_RECURSION_DEPTH:
        raise RecursionError("maximum recursion depth reached for serialization")

Could you create a GH issue in the meantime, so it isn't forgotten?

[nailo2c]

sure, let me create a GH issue later

[nailo2c]

The GH issue: #51915