feat: Add lazy filtering support for inlet events by time range, ordering, and limit#54891
Merged
Merged
Conversation
hussein-awala
marked this pull request as ready for review
August 26, 2025 22:46
hussein-awala
requested review from
amoghrajesh,
ashb and
kaxil
as code owners
August 26, 2025 22:46
hussein-awala
requested review from
Lee-W,
eladkal,
potiuk,
shahar1 and
uranusjr
August 26, 2025 22:48
Lee-W
reviewed
Aug 27, 2025
hussein-awala
force-pushed
the
inlet_events_filers
branch
from
August 29, 2025 09:54
3966bea to
4470f46
Compare
Contributor
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
uranusjr
approved these changes
Oct 20, 2025
uranusjr
left a comment
Member
There was a problem hiding this comment.
There are some optimisation to be had (specifically how we calculate _asset_events for verious things, somethings not needed), but I’m happy with the interface and we can just improve incrementally when we feel like doing it.
Lee-W
approved these changes
Oct 20, 2025
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Oct 20, 2025
TyrellHaywood
pushed a commit
to TyrellHaywood/airflow
that referenced
this pull request
Oct 22, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the asset events API client and inlet events accessor to support additional query options while keeping the accessor lazy, meaning events are only fetched when accessed.
Changes
InletEventsAccessors.__getitem__to accept optional filtering arguments (after,before,ascending,limit) without breaking existing usage (new key type istuple[<existing key type>, dict])SUPERVISOR_COMMSonly when accessed, but it will only fetch the events that match the filters when they are provided.Impact
accessors[asset]continue to work as before.Use Cases
ascending=Falseandlimit=1).