Skip to content

Simple sending of return value from Go tasks to XCom#56481

Merged
ashb merged 1 commit into
mainfrom
go-sdk-pushmi
Oct 9, 2025
Merged

Simple sending of return value from Go tasks to XCom#56481
ashb merged 1 commit into
mainfrom
go-sdk-pushmi

Conversation

@ashb

@ashb ashb commented Oct 8, 2025

Copy link
Copy Markdown
Member

This right now is very simple and will need to evolve over time -- it doens't
support XCom backends for instance.

We also don't handle any of the "serialization" format for more advanced
types, such as datetime/time.Time etc. That will come later

In order to call this HTPT API correctly we needed to update the client generator.

Comment thread go-sdk/pkg/worker/task.go

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an (unused) old copy of go-sdk/bundle/bundlev1/task.go -- I removed it here to avoid it being out of date and still confusing.

@ashb ashb marked this pull request as ready for review October 8, 2025 16:49
@ashb ashb requested review from amoghrajesh and kaxil as code owners October 8, 2025 16:49

@amoghrajesh amoghrajesh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits and a qn -- looks good otherwise.

Comment thread go-sdk/bundle/bundlev1/task.go Outdated
Comment thread go-sdk/sdk/client.go Outdated
Comment thread go-sdk/sdk/client.go

@amoghrajesh amoghrajesh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits and a qn -- looks good otherwise.

This right now is very simple and will need to evolve over time -- it doens't
support XCom backends for instance.

We also don't handle any of the "serialization" format for more advanced
types, such as datetime/time.Time etc. That will come later
@ashb ashb merged commit 8400602 into main Oct 9, 2025
51 checks passed
@ashb ashb deleted the go-sdk-pushmi branch October 9, 2025 00:01
dabla pushed a commit to dabla/airflow that referenced this pull request Oct 12, 2025
This right now is very simple and will need to evolve over time -- it doens't
support XCom backends for instance.

We also don't handle any of the "serialization" format for more advanced
types, such as datetime/time.Time etc. That will come later
TyrellHaywood pushed a commit to TyrellHaywood/airflow that referenced this pull request Oct 22, 2025
This right now is very simple and will need to evolve over time -- it doens't
support XCom backends for instance.

We also don't handle any of the "serialization" format for more advanced
types, such as datetime/time.Time etc. That will come later
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants