Change default on_finish_action to 'delete_pod'#58279
Closed
jroachgolf84 wants to merge 3 commits into
Closed
Conversation
boring-cyborg
Bot
added
area:providers
provider:google
Collaborator
Author
|
@rawwar - mind taking a peek at this one? |
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Author
|
@rawwar, can you take a look at the updated PR? Thanks! |
Collaborator
Author
|
@rawwar, bumping this up again. |
Lee-W
reviewed
Dec 9, 2025
Member
Lee-W
left a comment
Lee-W
left a comment
There was a problem hiding this comment.
could we add a unit test for it? Check the default value after initialization should be enough
Contributor
|
@jroachgolf84 hey, are you still working on it? |
Collaborator
Author
|
@shahar1, apologies; I haven't written those unit-tests yet. I'm happy to finish that before the EoM. Or, if there is a contributor that's interested in doing this, I'm happy to turn it over to them :). |
Contributor
|
Original issue will be fixed in #60960. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updating the docs to appropriately reflect the default behavior for the
on_finish_actionparameter in theGKEStartPodOperator.closes: #58272