Copy Self to observability shared package#59140
Conversation
Shared packages should not refer to airflow or airflow.sdk. This is the last "airflow" import remaining in the observability package. Fixed during implementation of apache#58825
|
cc: @xBis7 |
xBis7
left a comment
There was a problem hiding this comment.
Nice and simple fix. It makes sense to duplicate the code since I can see that only observability uses it from shared. LGTM!
|
Since its only used for type checking, cant we just add the "typing-extensions" path? |
I think not - I prefer not to depend on "typing-extensions" version of "Self" when we are already on Python 3.11+ in this case. Also having it this way makes it easy to have "rolling deprecation removal". When we move to Python 3.11+ next October - we will know we have to remove this completely. If we import from |
Sounds ok, thanks. |
Shared packages should not refer to airflow or airflow.sdk. This is the last "airflow" import remaining in the observability package. Fixed during implementation of apache#58825
Shared packages should not refer to airflow or airflow.sdk. This is the last "airflow" import remaining in the observability package. Fixed during implementation of apache#58825
Shared packages should not refer to airflow or airflow.sdk. This is the last "airflow" import remaining in the observability package. Fixed during implementation of apache#58825
Shared packages should not refer to airflow or airflow.sdk. This is the last "airflow" import remaining in the observability package.
Fixed during implementation of #58825
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.