Fix incorrect compute param example in SageMakerNotebookHook docstring#60247
Conversation
The compute parameter example incorrectly shows `image_uri` as a direct field, but the SageMaker Unified Studio API expects `image_details` with either `ecr_uri` or `image_name`/`image_version` combination. Reference: https://docs.aws.amazon.com/sagemaker-unified-studio/latest/userguide/remote-execution-apis.html#remote-start-execution
The compute parameter example incorrectly shows `image_uri` as a direct field, but the SageMaker Unified Studio API expects `image_details` with either `ecr_uri` or `image_name`/`image_version` combination. Reference: https://docs.aws.amazon.com/sagemaker-unified-studio/latest/userguide/remote-execution-apis.html#remote-start-execution
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
vincbeck
left a comment
There was a problem hiding this comment.
Looks good to me but some tests need to be fixed
+1, sphinx gets very upset when there is indented code looking examples in the docs. I reckon this is why it was all on one line previously. Your PR for this fix doesn't necessarily need to include that reformatting. The easiest fix would be to just put it back to a single line. |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
apache#60247) * Fix incorrect compute param example in SageMakerNotebookHook docstring The compute parameter example incorrectly shows `image_uri` as a direct field, but the SageMaker Unified Studio API expects `image_details` with either `ecr_uri` or `image_name`/`image_version` combination. Reference: https://docs.aws.amazon.com/sagemaker-unified-studio/latest/userguide/remote-execution-apis.html#remote-start-execution * Fix incorrect compute param example in SageMakerNotebookHook docstring The compute parameter example incorrectly shows `image_uri` as a direct field, but the SageMaker Unified Studio API expects `image_details` with either `ecr_uri` or `image_name`/`image_version` combination. Reference: https://docs.aws.amazon.com/sagemaker-unified-studio/latest/userguide/remote-execution-apis.html#remote-start-execution
apache#60247) * Fix incorrect compute param example in SageMakerNotebookHook docstring The compute parameter example incorrectly shows `image_uri` as a direct field, but the SageMaker Unified Studio API expects `image_details` with either `ecr_uri` or `image_name`/`image_version` combination. Reference: https://docs.aws.amazon.com/sagemaker-unified-studio/latest/userguide/remote-execution-apis.html#remote-start-execution * Fix incorrect compute param example in SageMakerNotebookHook docstring The compute parameter example incorrectly shows `image_uri` as a direct field, but the SageMaker Unified Studio API expects `image_details` with either `ecr_uri` or `image_name`/`image_version` combination. Reference: https://docs.aws.amazon.com/sagemaker-unified-studio/latest/userguide/remote-execution-apis.html#remote-start-execution
apache#60247) * Fix incorrect compute param example in SageMakerNotebookHook docstring The compute parameter example incorrectly shows `image_uri` as a direct field, but the SageMaker Unified Studio API expects `image_details` with either `ecr_uri` or `image_name`/`image_version` combination. Reference: https://docs.aws.amazon.com/sagemaker-unified-studio/latest/userguide/remote-execution-apis.html#remote-start-execution * Fix incorrect compute param example in SageMakerNotebookHook docstring The compute parameter example incorrectly shows `image_uri` as a direct field, but the SageMaker Unified Studio API expects `image_details` with either `ecr_uri` or `image_name`/`image_version` combination. Reference: https://docs.aws.amazon.com/sagemaker-unified-studio/latest/userguide/remote-execution-apis.html#remote-start-execution
apache#60247) * Fix incorrect compute param example in SageMakerNotebookHook docstring The compute parameter example incorrectly shows `image_uri` as a direct field, but the SageMaker Unified Studio API expects `image_details` with either `ecr_uri` or `image_name`/`image_version` combination. Reference: https://docs.aws.amazon.com/sagemaker-unified-studio/latest/userguide/remote-execution-apis.html#remote-start-execution * Fix incorrect compute param example in SageMakerNotebookHook docstring The compute parameter example incorrectly shows `image_uri` as a direct field, but the SageMaker Unified Studio API expects `image_details` with either `ecr_uri` or `image_name`/`image_version` combination. Reference: https://docs.aws.amazon.com/sagemaker-unified-studio/latest/userguide/remote-execution-apis.html#remote-start-execution
apache#60247) * Fix incorrect compute param example in SageMakerNotebookHook docstring The compute parameter example incorrectly shows `image_uri` as a direct field, but the SageMaker Unified Studio API expects `image_details` with either `ecr_uri` or `image_name`/`image_version` combination. Reference: https://docs.aws.amazon.com/sagemaker-unified-studio/latest/userguide/remote-execution-apis.html#remote-start-execution * Fix incorrect compute param example in SageMakerNotebookHook docstring The compute parameter example incorrectly shows `image_uri` as a direct field, but the SageMaker Unified Studio API expects `image_details` with either `ecr_uri` or `image_name`/`image_version` combination. Reference: https://docs.aws.amazon.com/sagemaker-unified-studio/latest/userguide/remote-execution-apis.html#remote-start-execution
The compute parameter example in
SageMakerNotebookHookandSageMakerNotebookOperatordocstrings incorrectly showsimage_urias a direct field, but the SageMaker Unified Studio API expectsimage_detailswith eitherecr_uriorimage_name/image_versioncombination.Reference: https://docs.aws.amazon.com/sagemaker-unified-studio/latest/userguide/remote-execution-apis.html#remote-start-execution