Skip to content

Use mprocs by default with start-airflow#60844

Merged
potiuk merged 1 commit into
apache:mainfrom
potiuk:switch-to-mprocs-by-default
Jan 22, 2026
Merged

Use mprocs by default with start-airflow#60844
potiuk merged 1 commit into
apache:mainfrom
potiuk:switch-to-mprocs-by-default

Conversation

@potiuk

@potiuk potiuk commented Jan 21, 2026

Copy link
Copy Markdown
Member

This change will:

  • use mprocs by default for start-airflow
  • allows to switch to tmux by --terminal-multiplexer tmux
  • stores last used selection permanently for subsequent runs
  • allows to switch multiplexer by breeze setup config
  • only print mprocs generated config when --verbose flag is used
Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@choo121600

choo121600 commented Jan 21, 2026

Copy link
Copy Markdown
Member

COOL🙌

jscheffl
jscheffl approved these changes Jan 21, 2026
View reviewed changes

@jscheffl jscheffl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

One nit as comment and one final question: Can we assume mprocs is always available as built into the container to do we need to check if existing and have a fallback?

Comment thread dev/breeze/src/airflow_breeze/commands/common_options.py
@potiuk
Use mprocs by default with start-airflow
7f152b0 
This change will:

* use mprocs by default for start-airflow
* allows to switch to tmux by --terminal-multiplexer tmux
* stores last used selection permanently for subsequent runs
* allows to switch multiplexer by `breeze setup config`
* only print mprocs generated config when --verbose flag is used
@potiuk
potiuk force-pushed the switch-to-mprocs-by-default branch from 5532426 to 7f152b0 Compare January 21, 2026 19:41
@potiuk

potiuk commented Jan 21, 2026

Copy link
Copy Markdown
Member Author

Can we assume mprocs is always available as built into the container to do we need to check if existing and have a fallback?

Yes. Mprocs is added when bulding CI image.

jason810496
jason810496 approved these changes Jan 22, 2026
View reviewed changes

@jason810496 jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested it locally, and it LGTM. Thanks!

@potiuk
potiuk merged commit 9b47c56 into apache:main Jan 22, 2026
246 of 248 checks passed
@potiuk
potiuk deleted the switch-to-mprocs-by-default branch January 22, 2026 23:40
@github-actions

github-actions Bot commented Jan 22, 2026

Copy link
Copy Markdown
Contributor

Backport failed to create: v3-1-test. View the failure log Run details

Status Branch Result
❌ v3-1-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 9b47c56 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

@potiuk potiuk mentioned this pull request Jan 23, 2026
Open
2 tasks
suii2210 pushed a commit to suii2210/airflow that referenced this pull request Jan 26, 2026
@potiuk @suii2210
Use mprocs by default with start-airflow (apache#60844)
127ff65 
This change will:

* use mprocs by default for start-airflow
* allows to switch to tmux by --terminal-multiplexer tmux
* stores last used selection permanently for subsequent runs
* allows to switch multiplexer by `breeze setup config`
* only print mprocs generated config when --verbose flag is used
shreyas-dev pushed a commit to shreyas-dev/airflow that referenced this pull request Jan 29, 2026
@potiuk @shreyas-dev
Use mprocs by default with start-airflow (apache#60844)
b96b852 
This change will:

* use mprocs by default for start-airflow
* allows to switch to tmux by --terminal-multiplexer tmux
* stores last used selection permanently for subsequent runs
* allows to switch multiplexer by `breeze setup config`
* only print mprocs generated config when --verbose flag is used
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
@potiuk @jhgoebbert
Use mprocs by default with start-airflow (apache#60844)
a8ba87e 
This change will:

* use mprocs by default for start-airflow
* allows to switch to tmux by --terminal-multiplexer tmux
* stores last used selection permanently for subsequent runs
* allows to switch multiplexer by `breeze setup config`
* only print mprocs generated config when --verbose flag is used
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
@potiuk @choo121600
Use mprocs by default with start-airflow (apache#60844)
4afc9a8 
This change will:

* use mprocs by default for start-airflow
* allows to switch to tmux by --terminal-multiplexer tmux
* stores last used selection permanently for subsequent runs
* allows to switch multiplexer by `breeze setup config`
* only print mprocs generated config when --verbose flag is used
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
@potiuk @Subham-KRLX
Use mprocs by default with start-airflow (apache#60844)
ef46260 
This change will:

* use mprocs by default for start-airflow
* allows to switch to tmux by --terminal-multiplexer tmux
* stores last used selection permanently for subsequent runs
* allows to switch multiplexer by `breeze setup config`
* only print mprocs generated config when --verbose flag is used
Ankurdeewan pushed a commit to Ankurdeewan/airflow that referenced this pull request Mar 15, 2026
@potiuk @Ankurdeewan
Use mprocs by default with start-airflow (apache#60844)
0d665e2 
This change will:

* use mprocs by default for start-airflow
* allows to switch to tmux by --terminal-multiplexer tmux
* stores last used selection permanently for subsequent runs
* allows to switch multiplexer by `breeze setup config`
* only print mprocs generated config when --verbose flag is used
@RoyLee1224 RoyLee1224 mentioned this pull request Jul 21, 2026
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jason810496 jason810496 jason810496 approved these changes
@jscheffl jscheffl jscheffl approved these changes
@ashb ashb Awaiting requested review from ashb ashb is a code owner
@gopidesupavan gopidesupavan Awaiting requested review from gopidesupavan gopidesupavan is a code owner
@amoghrajesh amoghrajesh Awaiting requested review from amoghrajesh amoghrajesh is a code owner
@bugraoz93 bugraoz93 Awaiting requested review from bugraoz93 bugraoz93 is a code owner
@kaxil kaxil Awaiting requested review from kaxil
@jedcunningham jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner
@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

Assignees

No one assigned

Labels

area:dev-tools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@potiuk @choo121600 @jason810496 @jscheffl