Skip to content

Git provider should require common-compat >=1.12.0#60985

Merged
ephraimbuddy merged 3 commits into
apache:mainfrom
astronomer:update-git-provider-common-req
Jan 27, 2026
Merged

Git provider should require common-compat >=1.12.0#60985
ephraimbuddy merged 3 commits into
apache:mainfrom
astronomer:update-git-provider-common-req

Conversation

@ephraimbuddy
Copy link
Copy Markdown
Contributor

@ephraimbuddy ephraimbuddy commented Jan 23, 2026

Using git provider 0.2.1 with common.compat <1.12 causes issues in dag callbacks

ashb
ashb reviewed Jan 23, 2026
View reviewed changes
Comment thread providers/git/pyproject.toml Outdated
@Prab-27
Copy link
Copy Markdown
Contributor

Prab-27 commented Jan 23, 2026 •
edited
Loading

Could we update this as - apache-airflow-providers-common-compat>=1.12.0 like teradata and exasol

eladkal
eladkal reviewed Jan 24, 2026
View reviewed changes
Comment thread providers/git/pyproject.toml Outdated
ephraimbuddy and others added 2 commits January 25, 2026 08:57
@ephraimbuddy
Git provider should require common-compat >=1.12.0
f62a9a1 
Using git provider 0.2.1 with common.compat <1.12 causes issues in dag callbacks
@ephraimbuddy @eladkal
Update providers/git/pyproject.toml
de51ff8 
Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
@ephraimbuddy ephraimbuddy force-pushed the update-git-provider-common-req branch from 30c283d to de51ff8 Compare January 25, 2026 07:57
@eladkal
Copy link
Copy Markdown
Contributor

eladkal commented Jan 25, 2026

I think we have a bug with the # use next version
The test should not fail for this PR

@ephraimbuddy
Copy link
Copy Markdown
Contributor Author

ephraimbuddy commented Jan 26, 2026

I think we have a bug with the # use next version The test should not fail for this PR

I remember being told by @jscheffl that the update should only be done by release manager. That was why I used the # use next version

@eladkal eladkal closed this Jan 26, 2026
@eladkal eladkal reopened this Jan 26, 2026
@eladkal
Copy link
Copy Markdown
Contributor

eladkal commented Jan 26, 2026

I think we have a bug with the # use next version The test should not fail for this PR

I remember being told by @jscheffl that the update should only be done by release manager. That was why I used the # use next version

Added label to override

@jscheffl
Copy link
Copy Markdown
Contributor

jscheffl commented Jan 26, 2026

I think we have a bug with the # use next version The test should not fail for this PR

I remember being told by @jscheffl that the update should only be done by release manager. That was why I used the # use next version

No, is only needed if the common.compat also is pending release (because something changed there) so that a marker is there that common-compat has increased version, the dependency is bumped accordingly.

If you are referring to featutes already released in 1.12.0 then it is good.

@eladkal
Copy link
Copy Markdown
Contributor

eladkal commented Jan 26, 2026

If you are referring to featutes already released in 1.12.0 then it is good.

ideally yes but something is still broken with the scripts as the test is failing. I am not sure if I will have time to look into this in the up coming days

@Prab-27
Copy link
Copy Markdown
Contributor

Prab-27 commented Jan 27, 2026

Does this fine to update the failing docs checks - here since it's just require dependency docs and get all green to merge this

@eladkal
Copy link
Copy Markdown
Contributor

eladkal commented Jan 27, 2026

ah yeah
@ephraimbuddy you need to run pre-commits on this PR so index.rst will be updated

@ephraimbuddy ephraimbuddy merged commit 7c1e49a into apache:main Jan 27, 2026
101 checks passed
@ephraimbuddy ephraimbuddy deleted the update-git-provider-common-req branch January 27, 2026 10:40
amoghrajesh
amoghrajesh reviewed Jan 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks

@vincbeck vincbeck mentioned this pull request Jan 28, 2026
Closed
85 tasks
shreyas-dev pushed a commit to shreyas-dev/airflow that referenced this pull request Jan 29, 2026
@ephraimbuddy @eladkal @shreyas-dev
Git provider should require common-compat >=1.12.0 (apache#60985)
38dfebd 
* Git provider should require common-compat >=1.12.0

Using git provider 0.2.1 with common.compat <1.12 causes issues in dag callbacks

* Update providers/git/pyproject.toml

Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>

* fixup! Update providers/git/pyproject.toml

---------

Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
shashbha14 pushed a commit to shashbha14/airflow that referenced this pull request Feb 2, 2026
@ephraimbuddy @eladkal
Git provider should require common-compat >=1.12.0 (apache#60985)
bf2b441 
* Git provider should require common-compat >=1.12.0

Using git provider 0.2.1 with common.compat <1.12 causes issues in dag callbacks

* Update providers/git/pyproject.toml

Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>

* fixup! Update providers/git/pyproject.toml

---------

Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
jason810496 pushed a commit to abhijeets25012-tech/airflow that referenced this pull request Feb 3, 2026
@ephraimbuddy @eladkal @jason810496
Git provider should require common-compat >=1.12.0 (apache#60985)
b5c2a25 
* Git provider should require common-compat >=1.12.0

Using git provider 0.2.1 with common.compat <1.12 causes issues in dag callbacks

* Update providers/git/pyproject.toml

Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>

* fixup! Update providers/git/pyproject.toml

---------

Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
@ephraimbuddy @eladkal @jhgoebbert
Git provider should require common-compat >=1.12.0 (apache#60985)
3230812 
* Git provider should require common-compat >=1.12.0

Using git provider 0.2.1 with common.compat <1.12 causes issues in dag callbacks

* Update providers/git/pyproject.toml

Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>

* fixup! Update providers/git/pyproject.toml

---------

Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
@ephraimbuddy @eladkal @choo121600
Git provider should require common-compat >=1.12.0 (apache#60985)
d8ce527 
* Git provider should require common-compat >=1.12.0

Using git provider 0.2.1 with common.compat <1.12 causes issues in dag callbacks

* Update providers/git/pyproject.toml

Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>

* fixup! Update providers/git/pyproject.toml

---------

Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
@ephraimbuddy @eladkal @Subham-KRLX
Git provider should require common-compat >=1.12.0 (apache#60985)
9a79541 
* Git provider should require common-compat >=1.12.0

Using git provider 0.2.1 with common.compat <1.12 causes issues in dag callbacks

* Update providers/git/pyproject.toml

Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>

* fixup! Update providers/git/pyproject.toml

---------

Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
Ankurdeewan pushed a commit to Ankurdeewan/airflow that referenced this pull request Mar 15, 2026
@ephraimbuddy @eladkal @Ankurdeewan
Git provider should require common-compat >=1.12.0 (apache#60985)
df81fda 
* Git provider should require common-compat >=1.12.0

Using git provider 0.2.1 with common.compat <1.12 causes issues in dag callbacks

* Update providers/git/pyproject.toml

Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>

* fixup! Update providers/git/pyproject.toml

---------

Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashb ashb ashb left review comments

@amoghrajesh amoghrajesh amoghrajesh left review comments

@eladkal eladkal eladkal approved these changes

Assignees

No one assigned

Labels

allow provider dependency bump area:providers provider:git

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ephraimbuddy @Prab-27 @eladkal @jscheffl @ashb @amoghrajesh