Fix metric emitting for triggerer and dag processor#61154
Conversation
After a recent refactoring (apache#53722) a call to an initializer for stats is required but was not done for the dag processor or triggerer
|
Hi @o-nikolas, thanks for pinging me. The The result is that every new process has to call |
Thanks for the context @xBis7 I figured that was the case. Do you mind giving these changes a review? |
|
@o-nikolas What are you using for testing? |
Yup!
|
xBis7
left a comment
There was a problem hiding this comment.
Changes LGTM! I tested it manually and I was able to reproduce the issue and verify that the changes in this patch, fix it. Thanks!
After a recent refactoring (apache#53722) a call to an initializer for stats is required but was not done for the dag processor or triggerer
After a recent refactoring (apache#53722) a call to an initializer for stats is required but was not done for the dag processor or triggerer
After a recent refactoring (apache#53722) a call to an initializer for stats is required but was not done for the dag processor or triggerer
After a recent refactoring (apache#53722) a call to an initializer for stats is required but was not done for the dag processor or triggerer
After a recent refactoring (apache#53722) a call to an initializer for stats is required but was not done for the dag processor or triggerer
After a recent refactoring (apache#53722) a call to an initializer for stats is required but was not done for the dag processor or triggerer
After a recent refactoring (apache#53722) a call to an initializer for stats is required but was not done for the dag processor or triggerer
After a recent refactoring (#53722) a call to an initializer for stats is required but was not done for the dag processor or triggerer. I noticed this when going to manually test some of my metrics related changes in breeze.
Tested manually in Breeze with and without these changes and metrics appear with these fixes.
I'm curious to hear from @xBis7 since he was the original author of the above changes.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.