Skip to content

Change serialization inside GenAIGeminiCreateBatchJobOperator#61253

Merged
vincbeck merged 1 commit into
apache:mainfrom
VladaZakharova:change-serialization-gen-ai-create-batch-job
Feb 2, 2026
Merged

Change serialization inside GenAIGeminiCreateBatchJobOperator#61253
vincbeck merged 1 commit into
apache:mainfrom
VladaZakharova:change-serialization-gen-ai-create-batch-job

Conversation

@Crowiant
Copy link
Copy Markdown
Contributor

Fix #61116

Found serialization error on Airflow 2. This PR will unblock the release of a new version of google provider.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Copy link
Copy Markdown
Contributor

@shahar1 shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just figured out that we are lacking unit tests for gen_ai operators module entirely.
I'll be happy if you could at some for the modified methods as part of this PR.

For the rest of the operators - I created #61261 (I'd like to handle it before the next release, to prevent potential regressions in the future).
Thank you!

CC: @VladaZakharova @MaksYermak

@MaksYermak
Copy link
Copy Markdown
Contributor

I just figured out that we are lacking unit tests for gen_ai operators module entirely. I'll be happy if you could at some for the modified methods as part of this PR.

For the rest of the operators - I created #61261 (I'd like to handle it before the next release, to prevent potential regressions in the future). Thank you!

CC: @VladaZakharova @MaksYermak

Hello @shahar1,
We have unit tests for GenAI operators here https://github.com/apache/airflow/blob/main/providers/google/tests/unit/google/cloud/operators/test_gen_ai.py. Please clarify for me if I misunderstood you and you meant some additional unit tests to the existing one?

@shahar1
Copy link
Copy Markdown
Contributor

shahar1 commented Feb 2, 2026

I just figured out that we are lacking unit tests for gen_ai operators module entirely. I'll be happy if you could at some for the modified methods as part of this PR.

For the rest of the operators - I created #61261 (I'd like to handle it before the next release, to prevent potential regressions in the future). Thank you!

CC: @VladaZakharova @MaksYermak

Hello @shahar1,
We have unit tests for GenAI operators here https://github.com/apache/airflow/blob/main/providers/google/tests/unit/google/cloud/operators/test_gen_ai.py. Please clarify for me if I misunderstood you and you meant some additional unit tests to the existing one?

Wow, somehow I've completely missed this one! My apologies.
So just add unit tests for the existing changes and I'll get this merged.

@Crowiant Crowiant force-pushed the change-serialization-gen-ai-create-batch-job branch from 12cc137 to 6c14c00 Compare February 2, 2026 14:48
@Crowiant
Copy link
Copy Markdown
Contributor Author

Crowiant commented Feb 2, 2026

Hello @shahar1 could you please review the PR? I added unit tests as you requested. Thank you!

@vincbeck
Copy link
Copy Markdown
Contributor

vincbeck commented Feb 2, 2026

Merging now and I'll get it released today/tomorrow. The test failing is failing in main so this is not relevant to the PR

@vincbeck vincbeck merged commit 1129231 into apache:main Feb 2, 2026
165 of 166 checks passed
jason810496 pushed a commit to abhijeets25012-tech/airflow that referenced this pull request Feb 3, 2026
…#61253)

Co-authored-by: Anton Nitochkin <nitochkin@google.com>
Alok-kumar-priyadarshi pushed a commit to Alok-kumar-priyadarshi/airflow that referenced this pull request Feb 5, 2026
…#61253)

Co-authored-by: Anton Nitochkin <nitochkin@google.com>
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
…#61253)

Co-authored-by: Anton Nitochkin <nitochkin@google.com>
Ratasa143 pushed a commit to Ratasa143/airflow that referenced this pull request Feb 15, 2026
…#61253)

Co-authored-by: Anton Nitochkin <nitochkin@google.com>
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
…#61253)

Co-authored-by: Anton Nitochkin <nitochkin@google.com>
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
…#61253)

Co-authored-by: Anton Nitochkin <nitochkin@google.com>
Ankurdeewan pushed a commit to Ankurdeewan/airflow that referenced this pull request Mar 15, 2026
…#61253)

Co-authored-by: Anton Nitochkin <nitochkin@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants