Skip to content

Fix test connection to ignore masked password placeholder #61739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jaymasiwal wants to merge 1 commit into from
Closed

Fix test connection to ignore masked password placeholder #61739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions airflow-core/src/airflow/api_fastapi/core_api/routes/public/connections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
# under the License.
from __future__ import annotations

from airflow._shared.secrets_masker import MASKED_VALUE

import os
from typing import Annotated

Expand Down Expand Up @@ -235,6 +237,11 @@ def test_connection(test_body: ConnectionBody) -> ConnectionTestResponse:
try:
existing_conn = Connection.get_connection_from_secrets(test_body.connection_id)
existing_conn.conn_id = transient_conn_id

# If password is masked placeholder, do not override stored secret
if test_body.password == MASKED_VALUE:
test_body = test_body.model_copy(update={"password": None})

update_orm_from_pydantic(existing_conn, test_body)
conn = existing_conn
except AirflowNotFoundException:
Expand Down
Loading