Add multi-team support for KubernetesExecutor#61798
Conversation
06ecff2 to
39656ac
Compare
|
Note on Switching config reads from The |
jscheffl
left a comment
There was a problem hiding this comment.
Some small revision needed, else from code look good in my view
Can you maybe add an inline comment about this for people seeing this after merging and looking at the code? |
39656ac to
ddecc3f
Compare
Added inline comments |
|
#60912 @o-nikolas Please review this PR |
o-nikolas
left a comment
There was a problem hiding this comment.
Thanks for the PR! A few comments. Also what kind of manual QA have you done?
|
Hey @vbottu just checking in to see how this is coming along? |
|
Hey @vbottu Checking in again on this one. Any progress on the testing or feedback from the last review? |
|
Hello @o-nikolas , couldn't get to it, I will look into it tomorrow if that's okay. |
Lovely, thanks for following up 😃 |
50fdb3f to
3cde943
Compare
Tested this end to end on a KinD cluster. I set up two team namespaces |
jscheffl
left a comment
There was a problem hiding this comment.
In general OK, just two nit in my second pass. After fixing these I think it is good to merge.
o-nikolas
left a comment
There was a problem hiding this comment.
Other than Jen's feedback, lgtm. I re-triggered the failed builds since they don't immediately look related to me. Hopefully they are just flakey.
I assume the failures of the e2e UI tests are unrelated, but with next commit I assume / hope they will turn green. No need to worry about them |
Looks like the new build failed the same tests. Bringing in changes from main to see if that changes anything! |
Hint: Running once |
|
Sure , I will take a look , Thank you |
|
Merging from main one last time. Should fix the |
|
Some comments are still open, I assusme they are not complex to fix. Would be cool to address them - then we can merge it before next provider wave. |
working on them, will make the update soon |
* Add multi-team support for KubernetesExecutor * Address review feedback and fix configuration fallback bug * use AIRFLOW_V_3_2_PLUS version guard and narrow exception types --------- Co-authored-by: Niko Oliveira <onikolas@amazon.com>
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.