Skip to content

Fix serialization for return value in GenAIGeminiGetBatchJobOperator #61842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shahar1 merged 2 commits into from
Feb 14, 2026
Merged

Fix serialization for return value in GenAIGeminiGetBatchJobOperator #61842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ab0467
Fix serialization for return value in GenAIGeminiGetBatchJobOperator
MaksYermak Feb 12, 2026
5261391
Merge branch 'main' into fix-gen-ai-get-batch-serialization
shahar1 Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion providers/google/src/airflow/providers/google/cloud/operators/gen_ai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,7 +646,7 @@ def execute(self, context: Context):
raise AirflowException("Job with name %s not found", self.job_name)

context["ti"].xcom_push(key="job_status", value=job.state)
return dict(job)
return job.model_dump(mode="json")


class GenAIGeminiListBatchJobsOperator(GoogleCloudBaseOperator):
Expand Down
29 changes: 26 additions & 3 deletions providers/google/tests/unit/google/cloud/operators/test_gen_ai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
TEST_BATCH_JOB_NAME = "test-name"
TEST_FILE_NAME = "test-file"
TEST_FILE_PATH = "test/path/to/file"
TEST_CREATE_BATCH_JOB_RESPONSE = {
TEST_BATCH_JOB_RESPONSE = {
"src": None,
"dest": "test-batch-job-destination",
"name": "test-name",
Expand Down Expand Up @@ -317,7 +317,7 @@ def test_execute(self, mock_hook):

@mock.patch(GEN_AI_PATH.format("GenAIGeminiAPIHook"))
def test_execute_return_value(self, mock_hook):
expected_return = TEST_CREATE_BATCH_JOB_RESPONSE
expected_return = TEST_BATCH_JOB_RESPONSE

mock_job = mock.MagicMock()
mock_job.model_dump.return_value = expected_return
Expand All @@ -343,7 +343,7 @@ def test_execute_return_value(self, mock_hook):

@mock.patch(GEN_AI_PATH.format("GenAIGeminiAPIHook"))
def test_execute_complete_return_value(self, mock_hook):
expected_return = TEST_CREATE_BATCH_JOB_RESPONSE
expected_return = TEST_BATCH_JOB_RESPONSE

event = {"status": "success", "job_name": "test-name"}

Expand Down Expand Up @@ -391,6 +391,29 @@ def test_execute(self, mock_hook):
job_name=TEST_BATCH_JOB_NAME,
)

@mock.patch(GEN_AI_PATH.format("GenAIGeminiAPIHook"))
def test_execute_return_value(self, mock_hook):
expected_return = TEST_BATCH_JOB_RESPONSE

mock_job = mock.MagicMock()
mock_job.model_dump.return_value = expected_return
mock_hook.return_value.get_batch_job.return_value = mock_job

op = GenAIGeminiGetBatchJobOperator(
task_id=TASK_ID,
project_id=GCP_PROJECT,
location=GCP_LOCATION,
job_name=TEST_BATCH_JOB_NAME,
gcp_conn_id=GCP_CONN_ID,
impersonation_chain=IMPERSONATION_CHAIN,
gemini_api_key=TEST_GEMINI_API_KEY,
)

result = op.execute(context={"ti": mock.MagicMock()})

assert result == expected_return
mock_job.model_dump.assert_called_once_with(mode="json")


class TestGenAIGeminiListBatchJobsOperator:
@mock.patch(GEN_AI_PATH.format("GenAIGeminiAPIHook"))
Expand Down