Skip to content

Fix regression in security iframe navigation logic with basename #63141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pierrejeambrun merged 5 commits into from
Mar 12, 2026
Merged

Fix regression in security iframe navigation logic with basename #63141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d3b79d4
Fix regression in security iframe navigation logic with basename
Subham-KRLX Mar 8, 2026
516d25b
style: apply formatting to Security.tsx
Subham-KRLX Mar 9, 2026
90e868e
fix(ui): remove hardcoded localhost fallback from Security iframe nav…
Subham-KRLX Mar 9, 2026
ee4be68
Add newsfragment for security iframe basename fix
Subham-KRLX Mar 9, 2026
acd496f
Address review feedback: simplify security iframe navigation logic an…
Subham-KRLX Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions airflow-core/newsfragments/63141.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix security iframe navigation when AIRFLOW__API__BASE_URL basename is configured
Comment thread
pierrejeambrun marked this conversation as resolved.
11 changes: 7 additions & 4 deletions airflow-core/src/airflow/ui/src/pages/Security.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@
* under the License.
*/
import { Box } from "@chakra-ui/react";
import { useParams } from "react-router-dom";
import { useNavigate } from "react-router-dom";
import { useNavigate, useParams } from "react-router-dom";

import { useAuthLinksServiceGetAuthMenus } from "openapi/queries";
import { ProgressBar } from "src/components/ui";
Expand All @@ -43,8 +42,12 @@ export const Security = () => {
const onLoad = () => {
const iframe: HTMLIFrameElement | null = document.querySelector("#security-iframe");

if (iframe?.contentWindow && !iframe.contentWindow.location.pathname.startsWith("/auth/")) {
void Promise.resolve(navigate("/"));
if (iframe?.contentWindow) {
const base = new URL(document.baseURI).pathname.replace(/\/$/u, ""); // Remove trailing slash if exists

if (!iframe.contentWindow.location.pathname.startsWith(`${base}/auth/`)) {
void navigate("/");
}
}
Comment thread
bbovenzi marked this conversation as resolved.
};

Expand Down
Loading