fix(task-sdk): exclude pathlib.Path from resolve() call in templater#63306
Merged
Conversation
potiuk
approved these changes
Mar 10, 2026
YoannAbriel
force-pushed
the
fix/issue-55412
branch
3 times, most recently
from
d1a8687 to
6ba2449
Compare
…later pathlib.Path objects have a resolve() method for filesystem resolution (strict parameter), which conflicts with the Resolvable.resolve(context) protocol used by the templater. When a pathlib.Path subclass is passed as a templated field value, the templater incorrectly calls path.resolve(context), where the context dict is interpreted as strict=True, causing FileNotFoundError if the path doesn't exist. This adds an isinstance(value, os.PathLike) guard before calling resolve() to ensure pathlib.Path objects are returned as-is. Closes: apache#55412
YoannAbriel
force-pushed
the
fix/issue-55412
branch
from
6ba2449 to
36fa822
Compare
eladkal
approved these changes
Mar 15, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Mar 15, 2026
…ve() in templater (#63306) pathlib.Path objects have a resolve() method for filesystem resolution (strict parameter), which conflicts with the Resolvable.resolve(context) protocol used by the templater. When a pathlib.Path subclass is passed as a templated field value, the templater incorrectly calls path.resolve(context), where the context dict is interpreted as strict=True, causing FileNotFoundError if the path doesn't exist. This adds an isinstance(value, os.PathLike) guard before calling resolve() to ensure pathlib.Path objects are returned as-is. (cherry picked from commit 23dec8d) Co-authored-by: Yoann <60654707+YoannAbriel@users.noreply.github.com> Closes: #55412
Contributor
Backport successfully created: v3-1-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
eladkal
pushed a commit
that referenced
this pull request
Mar 15, 2026
…ve() in templater (#63306) (#63633) pathlib.Path objects have a resolve() method for filesystem resolution (strict parameter), which conflicts with the Resolvable.resolve(context) protocol used by the templater. When a pathlib.Path subclass is passed as a templated field value, the templater incorrectly calls path.resolve(context), where the context dict is interpreted as strict=True, causing FileNotFoundError if the path doesn't exist. This adds an isinstance(value, os.PathLike) guard before calling resolve() to ensure pathlib.Path objects are returned as-is. (cherry picked from commit 23dec8d) Closes: #55412 Co-authored-by: Yoann <60654707+YoannAbriel@users.noreply.github.com>
vatsrahul1001
pushed a commit
that referenced
this pull request
Mar 25, 2026
…ve() in templater (#63306) (#63633) pathlib.Path objects have a resolve() method for filesystem resolution (strict parameter), which conflicts with the Resolvable.resolve(context) protocol used by the templater. When a pathlib.Path subclass is passed as a templated field value, the templater incorrectly calls path.resolve(context), where the context dict is interpreted as strict=True, causing FileNotFoundError if the path doesn't exist. This adds an isinstance(value, os.PathLike) guard before calling resolve() to ensure pathlib.Path objects are returned as-is. (cherry picked from commit 23dec8d) Closes: #55412 Co-authored-by: Yoann <60654707+YoannAbriel@users.noreply.github.com>
abhijeets25012-tech
pushed a commit
to abhijeets25012-tech/airflow
that referenced
this pull request
Apr 9, 2026
…later (apache#63306) pathlib.Path objects have a resolve() method for filesystem resolution (strict parameter), which conflicts with the Resolvable.resolve(context) protocol used by the templater. When a pathlib.Path subclass is passed as a templated field value, the templater incorrectly calls path.resolve(context), where the context dict is interpreted as strict=True, causing FileNotFoundError if the path doesn't exist. This adds an isinstance(value, os.PathLike) guard before calling resolve() to ensure pathlib.Path objects are returned as-is. Closes: apache#55412
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #55412
pathlib.Path.resolve()takes an optionalstrictparameter, not acontextdict. The templater's duck-typedgetattr(value, "resolve", None)check matches pathlib objects, then callspath.resolve(context)— the dict is interpreted asstrict=True, raisingFileNotFoundErrorif the path doesn't exist.Added an
isinstance(value, os.PathLike)guard to skip pathlib-like objects before the resolve check.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4, claude-opus-4-6) following the guidelines