fix: use uuid_suffix in postgres unique constraint test expectations#63674
Merged
Conversation
The test expected SQL without ::UUID type cast for team_id, but SQLAlchemy v2 generates %(team_id)s::UUID on Postgres. The uuid_suffix variable was already defined for this purpose but not used. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jscheffl
approved these changes
Mar 15, 2026
vatsrahul1001
pushed a commit
that referenced
this pull request
Mar 25, 2026
…63674) The test expected SQL without ::UUID type cast for team_id, but SQLAlchemy v2 generates %(team_id)s::UUID on Postgres. The uuid_suffix variable was already defined for this purpose but not used. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_handle_single_column_unique_constraint_error_with_stacktracefor Pool and Variable%(team_id)s::UUIDtype cast in SQL on Postgres, but test expected%(team_id)swithout the castuuid_suffixvariable was already defined for this purpose (line 107) but was not used in the expected SQL stringsTest plan
Postgres tests: core / DB-core:Postgres:16:3.13:API...SerializationSpecial tests / Latest SQLAlchemy test🤖 Generated with Claude Code