Skip to content

[v3-1-test] Manually Backport fix(ui): handle pools with unlimited (-1) slots in UI components (#62831)#63872

Merged
pierrejeambrun merged 1 commit into
apache:v3-1-testfrom
choo121600:backport-b63857e-v3-1-test
Mar 18, 2026
Merged

[v3-1-test] Manually Backport fix(ui): handle pools with unlimited (-1) slots in UI components (#62831)#63872
pierrejeambrun merged 1 commit into
apache:v3-1-testfrom
choo121600:backport-b63857e-v3-1-test

Conversation

@choo121600

@choo121600 choo121600 commented Mar 18, 2026

Copy link
Copy Markdown
Member

Backport of #62831

  • fix(ui): handle pools with unlimited (-1) slots in UI components

When a pool has slots set to -1 (unlimited), the UI now properly handles this case instead of showing broken bars or negative values.

Changes:

  • PoolBar: render infinity symbol and proportional bar for unlimited pools
  • PoolBarCard: display ∞ instead of -1 in pool header
  • PoolSummary: correctly aggregate slots when any pool is unlimited
  • PoolForm: set min to -1 and add helper text explaining the convention

Closes: #61115

  • fix(ui): simplify PoolBar unlimited slots computation per review

  • fix(ui): rename short identifier in PoolBar filter/reduce

  • fix(ui): resolve linting and typing errors caught by prek

  • Fix indentation in PoolBar.tsx map callback (formatting)
  • Fix JSX line break in PoolBarCard.tsx (formatting)
  • Widen slotType cast to TaskInstanceState | "open" since open_slots produces "open" which is not a TaskInstanceState
  • Add explicit cast for StateIcon prop where "open" is already filtered out by infoSlots


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

…che#62831)

* fix(ui): handle pools with unlimited (-1) slots in UI components

When a pool has slots set to -1 (unlimited), the UI now properly
handles this case instead of showing broken bars or negative values.

Changes:
- PoolBar: render infinity symbol and proportional bar for unlimited pools
- PoolBarCard: display ∞ instead of -1 in pool header
- PoolSummary: correctly aggregate slots when any pool is unlimited
- PoolForm: set min to -1 and add helper text explaining the convention

Closes: apache#61115

* fix(ui): simplify PoolBar unlimited slots computation per review

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(ui): rename short identifier in PoolBar filter/reduce

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(ui): resolve linting and typing errors caught by prek

- Fix indentation in PoolBar.tsx map callback (formatting)
- Fix JSX line break in PoolBarCard.tsx (formatting)
- Widen slotType cast to TaskInstanceState | "open" since
  open_slots produces "open" which is not a TaskInstanceState
- Add explicit cast for StateIcon prop where "open" is already
  filtered out by infoSlots

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

@pierrejeambrun pierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pierrejeambrun pierrejeambrun merged commit 80b7936 into apache:v3-1-test Mar 18, 2026
59 checks passed
vatsrahul1001 pushed a commit that referenced this pull request Mar 25, 2026
) (#63872)

* fix(ui): handle pools with unlimited (-1) slots in UI components

When a pool has slots set to -1 (unlimited), the UI now properly
handles this case instead of showing broken bars or negative values.

Changes:
- PoolBar: render infinity symbol and proportional bar for unlimited pools
- PoolBarCard: display ∞ instead of -1 in pool header
- PoolSummary: correctly aggregate slots when any pool is unlimited
- PoolForm: set min to -1 and add helper text explaining the convention

Closes: #61115

* fix(ui): simplify PoolBar unlimited slots computation per review



* fix(ui): rename short identifier in PoolBar filter/reduce



* fix(ui): resolve linting and typing errors caught by prek

- Fix indentation in PoolBar.tsx map callback (formatting)
- Fix JSX line break in PoolBarCard.tsx (formatting)
- Widen slotType cast to TaskInstanceState | "open" since
  open_slots produces "open" which is not a TaskInstanceState
- Add explicit cast for StateIcon prop where "open" is already
  filtered out by infoSlots



---------

Co-authored-by: Antonio Mello <ajgcvm@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants