Skip to content

Pass try_number to extra links API - #65661

Merged
bbovenzi merged 9 commits into
apache:mainfrom
shashbha14:fix/try-number-extra-links-65354
Apr 30, 2026
Merged

Pass try_number to extra links API#65661
bbovenzi merged 9 commits into
apache:mainfrom
shashbha14:fix/try-number-extra-links-65354

Conversation

@shashbha14

@shashbha14 shashbha14 commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

In case a user chooses a retry from past attempts in the Details tab, the extra links were being created only for the latest attempt and not for the chosen retry attempt. This PR fixes that by passing try_number to the extra links API. This closes: #65354
Was generative AI tooling used to co-author this PR?

  • Yes — Claude Sonnet 4.6
    Generated-by: Claude Sonnet 4.6 following the guidelines
    '@

@boring-cyborg

boring-cyborg Bot commented Apr 22, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@boring-cyborg boring-cyborg Bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Apr 22, 2026
@shashbha14
shashbha14 marked this pull request as ready for review April 22, 2026 17:42
@potiuk potiuk added the ready for maintainer review Set after triaging when all criteria pass. label Apr 22, 2026
bbovenzi
bbovenzi reviewed Apr 23, 2026
View reviewed changes

@bbovenzi bbovenzi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good, just a few quick comments.

Comment thread airflow-core/newsfragments/65661.improvement.rst Outdated
Comment thread airflow-core/src/airflow/ui/src/pages/TaskInstance/ExtraLinks.tsx Outdated
Comment thread airflow-core/src/airflow/api_fastapi/core_api/routes/public/extra_links.py Outdated
@bbovenzi bbovenzi added this to the Airflow 3.2.2 milestone Apr 23, 2026
pierrejeambrun
pierrejeambrun reviewed Apr 23, 2026
View reviewed changes
Comment thread airflow-core/src/airflow/api_fastapi/core_api/routes/public/extra_links.py Outdated
Comment thread airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_extra_links.py Outdated
bbovenzi
bbovenzi requested changes Apr 23, 2026
View reviewed changes

@bbovenzi bbovenzi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching to request so we don't accidentally merge.

@shashbha14
shashbha14 requested review from XD-DENG and ashb as code owners April 23, 2026 18:02
@shashbha14
shashbha14 force-pushed the fix/try-number-extra-links-65354 branch from fbfc4d0 to 94a0262 Compare April 23, 2026 18:11
henry3260
henry3260 reviewed Apr 24, 2026
View reviewed changes

@henry3260 henry3260 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! The logic looks great to me.
I have one minor optimization suggestion:

Comment thread airflow-core/src/airflow/api_fastapi/core_api/routes/public/extra_links.py
@bbovenzi
bbovenzi merged commit d440726 into apache:main Apr 30, 2026
141 checks passed
@github-actions

github-actions Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
✅ v3-2-test PR Link

bbovenzi pushed a commit that referenced this pull request May 1, 2026
@github-actions @shashbha14 Shashwati
[v3-2-test] Pass try_number to extra links API (#65661) (#66171)
3e25e1f 
* Forward try_number to extra links API for correct retry links

* Rename newsfragment to match PR number

* Add tryNumber to generated OpenAPI query hooks

* Fix JSDoc param annotations for tryNumber in query hooks

* Address review: read tryNumber from searchParams, add comment, remove newsfragment

* Address review: use TaskInstanceHistory for past tries to ensure validation and immutability

* Fix ruff: remove duplicate test method and fix line length

* Optimize: query TaskInstance before DAG parsing to fail fast on missing TI

* Fix test: update missing_dag expected response after TI-first query reorder

---------
(cherry picked from commit d440726)

Co-authored-by: Shashwati Bhattacharyaa <166847329+shashbha14@users.noreply.github.com>
Co-authored-by: Shashwati <shashwatibhattacaharya21.2@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
@github-actions @shashbha14
Shashwati @vatsrahul1001
[v3-2-test] Pass try_number to extra links API (#65661) (#66171)
4f701dd 
* Forward try_number to extra links API for correct retry links

* Rename newsfragment to match PR number

* Add tryNumber to generated OpenAPI query hooks

* Fix JSDoc param annotations for tryNumber in query hooks

* Address review: read tryNumber from searchParams, add comment, remove newsfragment

* Address review: use TaskInstanceHistory for past tries to ensure validation and immutability

* Fix ruff: remove duplicate test method and fix line length

* Optimize: query TaskInstance before DAG parsing to fail fast on missing TI

* Fix test: update missing_dag expected response after TI-first query reorder

---------
(cherry picked from commit d440726)

Co-authored-by: Shashwati Bhattacharyaa <166847329+shashbha14@users.noreply.github.com>
Co-authored-by: Shashwati <shashwatibhattacaharya21.2@gmail.com>
@1fanwang 1fanwang mentioned this pull request Aug 11, 2026
Open
2 tasks
@waterWang waterWang mentioned this pull request Aug 11, 2026
Closed
1fanwang added a commit to 1fanwang/airflow that referenced this pull request Aug 11, 2026
@1fanwang
Return each attempt's own URL from operator extra links
2eb7d26 
Operator extra links are cached as XCom rows under the link's xcom_key, which
carries no attempt. XComOperatorLink.get_link receives a TaskInstanceKey and
ignores its try_number, so once a task retries, asking for an earlier attempt's
link returns the latest attempt's URL. apache#65661 made the endpoint resolve the
requested attempt, which makes the wrong answer reachable from the UI.

The worker now also caches the link under a key carrying the attempt that
produced it, and the reader prefers that row, falling back to the bare key for
links written before this change. Those rows are exempt from the clear a retry
issues, since they describe attempts that already ran.

The prefix is owned by Airflow rather than derived from the link's xcom_key,
because a link may override that with any name, as the Databricks and Google
links do.

Closes: apache#71471
Signed-off-by: 1fanwang <1fannnw@gmail.com>
1fanwang added a commit to 1fanwang/airflow that referenced this pull request Aug 12, 2026
@1fanwang
Return each attempt's own URL from operator extra links
664061b 
Operator extra links are cached as XCom rows under the link's xcom_key, which
carries no attempt. XComOperatorLink.get_link receives a TaskInstanceKey and
ignores its try_number, so once a task retries, asking for an earlier attempt's
link returns the latest attempt's URL. apache#65661 made the endpoint resolve the
requested attempt, which makes the wrong answer reachable from the UI.

The worker now also caches the link under a key carrying the attempt that
produced it, and the reader prefers that row, falling back to the bare key for
links written before this change. Those rows are exempt from the clear a retry
issues, since they describe attempts that already ran.

The prefix is owned by Airflow rather than derived from the link's xcom_key,
because a link may override that with any name, as the Databricks and Google
links do.

Closes: apache#71471
Signed-off-by: 1fanwang <1fannnw@gmail.com>
This was referenced Aug 12, 2026
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henry3260 henry3260 henry3260 left review comments
@bbovenzi bbovenzi bbovenzi approved these changes
@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner
@shubhamraj-git shubhamraj-git Awaiting requested review from shubhamraj-git shubhamraj-git is a code owner
@guan404ming guan404ming Awaiting requested review from guan404ming guan404ming is a code owner
@vatsrahul1001 vatsrahul1001 Awaiting requested review from vatsrahul1001 vatsrahul1001 is a code owner
@choo121600 choo121600 Awaiting requested review from choo121600 choo121600 is a code owner
@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner
@rawwar rawwar Awaiting requested review from rawwar rawwar is a code owner
@jason810496 jason810496 Awaiting requested review from jason810496 jason810496 is a code owner
@bugraoz93 bugraoz93 Awaiting requested review from bugraoz93 bugraoz93 is a code owner
@XD-DENG XD-DENG Awaiting requested review from XD-DENG XD-DENG is a code owner
@ashb ashb Awaiting requested review from ashb ashb is a code owner
@pierrejeambrun pierrejeambrun Awaiting requested review from pierrejeambrun pierrejeambrun is a code owner

Assignees

No one assigned

Labels

area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. ready for maintainer review Set after triaging when all criteria pass.

Projects

None yet

Milestone

Airflow 3.2.2

Development

Successfully merging this pull request may close these issues.

Pass try_number to extra links API so BaseOperatorLink.get_link can return per-attempt URLs

5 participants

@shashbha14 @bbovenzi @pierrejeambrun @henry3260 @potiuk