Skip to content

Fix Triggerer runner_health_check_threshold log formatting#66486

Merged
potiuk merged 1 commit into
apache:mainfrom
parkhojeong:fix/triggerer-runner-health-check-threshold-log-format
May 10, 2026
Merged

Fix Triggerer runner_health_check_threshold log formatting#66486
potiuk merged 1 commit into
apache:mainfrom
parkhojeong:fix/triggerer-runner-health-check-threshold-log-format

Conversation

@parkhojeong

@parkhojeong parkhojeong commented May 6, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #66412

Fix runner_health_check_threshold log formatting.

runner_health_check_threshold is read with conf.getfloat(...), but the log message previously used integer formatting (%ds). Fractional values such as 0.5 are now displayed correctly with %.1fs.

  • Changes:

    • Before: TriggerRunner ... (threshold: 30s) ...
    • After: TriggerRunner ... (threshold: 30.5s) ...
  • Repro

    • Run airflow-core/tests/unit/jobs/test_triggerer_job.py::test_heartbeat_watchdog
    • Temporarily patch the test with mocker.patch.object(type(supervisor), "runner_health_check_threshold", new=30.5) after the supervisor = supervisor_builder()

cc @jedcunningham @choo121600

@parkhojeong parkhojeong marked this pull request as ready for review May 7, 2026 02:34
@potiuk potiuk merged commit 7fa87bc into apache:main May 10, 2026
152 checks passed
jason810496 pushed a commit to jason810496/airflow that referenced this pull request May 11, 2026
@vatsrahul1001 vatsrahul1001 added this to the Airflow 3.3.0 milestone Jun 15, 2026
@vatsrahul1001 vatsrahul1001 added the type:bug-fix Changelog: Bug Fixes label Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Triggerer type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants