Log check_query_output response via format string in Snowflake SQL API hook - #67848
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
1d32130 to
2f50c84
Compare
potiuk
left a comment
There was a problem hiding this comment.
LGTM — lazy %s formatting with the query id is a clear improvement over log.info(response_json), which eagerly stringified and dropped context. Test updated to match. Thanks!
Drafted-by: Claude Code (Opus 4.8); reviewed by @potiuk before posting
|
Looks like azure provider tests are failing, but that has nothing to do with this PR |
|
Merged from main to see if past issues were solved |
5749a5f to
126fa0e
Compare
|
@shahar1 Looks like all tests are passing. can this be merged? |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Error:
SnowflakeSqlApiHook.check_query_outputlogs the raw response dict, which violatesStructuredLogMessage.event's str type.This prevents logs from being displayed in the UI after a deferred
SnowflakeSqlApiOperatorfinishes executing:Fix: Log the query response JSON in a templated string, matching the pattern used by other methods in the file.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.Important
🛠️ Maintainer triage note for @michaelneely · by
@potiuk· 2026-06-17 14:51 UTCHelpful heads-up from the maintainers — please address before this PR can be reviewed:
provider distributions tests / Compat 2.11.1:P3.10:,provider distributions tests / Compat 3.0.6:P3.10:,provider distributions tests / Compat 3.1.8:P3.10:,provider distributions tests / Compat 3.2.2:P3.10:. Reproduce and fix locally, then push.The ball is in your court — you've been assigned to this PR. Fix the above, then mark it Ready for review.
Automated triage — may be imperfect; a maintainer takes the next look.