Skip to content

Fix remote log provider type mismatch for callback-subprocess uploads #68290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Lee-W wants to merge 1 commit into from
Closed

Fix remote log provider type mismatch for callback-subprocess uploads #68290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion providers/alibaba/src/airflow/providers/alibaba/cloud/log/oss_task_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class OSSRemoteLogIO(LoggingMixin): # noqa: D101

processors = ()

def upload(self, path: os.PathLike | str, ti: RuntimeTI):
def upload(self, path: os.PathLike | str, ti: RuntimeTI | None = None) -> None:
"""Upload the given log path to the remote storage."""
path = Path(path)
if path.is_absolute():
Expand Down
2 changes: 1 addition & 1 deletion providers/amazon/src/airflow/providers/amazon/aws/log/cloudwatch_task_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ def close(self):

self.handler.flush()

def upload(self, path: os.PathLike | str, ti: RuntimeTI):
def upload(self, path: os.PathLike | str, ti: RuntimeTI | None = None) -> None:
"""Upload the given log path to the remote storage."""
# No batch upload — logs stream in real-time. Flush pending events and clean up.
self.close()
Expand Down
2 changes: 1 addition & 1 deletion providers/amazon/src/airflow/providers/amazon/aws/log/s3_task_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class S3RemoteLogIO(LoggingMixin): # noqa: D101

processors = ()

def upload(self, path: os.PathLike | str, ti: RuntimeTI):
def upload(self, path: os.PathLike | str, ti: RuntimeTI | None = None) -> None:
"""Upload the given log path to the remote storage."""
path = pathlib.Path(path)
if path.is_absolute():
Expand Down
2 changes: 1 addition & 1 deletion providers/apache/hdfs/src/airflow/providers/apache/hdfs/log/hdfs_task_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class HdfsRemoteLogIO(LoggingMixin): # noqa: D101

processors = ()

def upload(self, path: os.PathLike | str, ti: RuntimeTI):
def upload(self, path: os.PathLike | str, ti: RuntimeTI | None = None) -> None:
"""Upload the given log path to the remote storage."""
path = Path(path)
if path.is_absolute():
Expand Down
2 changes: 1 addition & 1 deletion providers/google/src/airflow/providers/google/cloud/log/gcs_task_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ class GCSRemoteLogIO(LoggingMixin): # noqa: D101

processors = ()

def upload(self, path: os.PathLike | str, ti: RuntimeTI):
def upload(self, path: os.PathLike | str, ti: RuntimeTI | None = None) -> None:
"""Upload the given log path to the remote storage."""
path = Path(path)
if path.is_absolute():
Expand Down
2 changes: 1 addition & 1 deletion providers/google/src/airflow/providers/google/cloud/log/stackdriver_task_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ def proc(

return (proc,)

def upload(self, path: os.PathLike | str, ti: RuntimeTI) -> None:
def upload(self, path: os.PathLike | str, ti: RuntimeTI | None = None) -> None:
"""Flush the transport and optionally delete local log files."""
self.transport.flush()
if self.delete_local_copy:
Expand Down
2 changes: 1 addition & 1 deletion providers/microsoft/azure/src/airflow/providers/microsoft/azure/log/wasb_task_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ class WasbRemoteLogIO(LoggingMixin): # noqa: D101

processors = ()

def upload(self, path: str | os.PathLike, ti: RuntimeTI):
def upload(self, path: str | os.PathLike, ti: RuntimeTI | None = None) -> None:
"""Upload the given log path to the remote storage."""
path = Path(path)
if path.is_absolute():
Expand Down
Loading