Fix repeated deletion attempts from adopted completed pods in kubernetes executor#68360
Fix repeated deletion attempts from adopted completed pods in kubernetes executor#68360styndall wants to merge 4 commits into
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
… completed updates out of result_queue loop
1ad4dfd to
abfd64a
Compare
jscheffl
left a comment
There was a problem hiding this comment.
Looks good for me - but unfortunately I lag a bit of understanding of K8sExecutor. Therefore another reviewer would be good not that I miss some side-effect. But change looks reasonable
Is there someone specific I can ping to have a K8sExecutor expert's eyes on this? |
|
@potiuk Are you able to review, or can you suggest the appropriate person? |
|
Nevermind, fixed by this PR while I was waiting for review. |
This PR fixes an issue where adopted completed pods are processed over and over without ever being removed from the completed pod set. We saw thousands of duplicate pod deletion attempts after adoption events.
The fix simply removes the completed pods' state change from the main result_queue processing loop, processing them after the result_queue has been drained, and then removes them as they get processed, requeueing any failures.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code