Feat note modal#68362
Conversation
pierrejeambrun
left a comment
There was a problem hiding this comment.
Markdown isn't renderd in the TI and table list on my end.
Screen.Recording.2026-06-11.at.17.07.35.mov
And also even in the task instance note, we're loosing some markdown capabilities, mapping is messed up, (spread operator + components is messing up the chakra mapping)
|
@pierrejeambrun Updated. I was playing with custom headers, but it messed the rest up @eladkal we removed that in 3.0 in order to show dag versioning in the grid view |
I am aware we removed it but I don't understand where is the conflict? I don't see version indication on the dagrun grid |
I think I remember the reasoning to remove it from Gris was (1) performance in the Grid query to fetch if note is existing (adds a join to note table) as (2) well as there was the feeling that the additional highlight "clutters" the view. I tend to say was beneficial to have the markers but frakly speaking most users did not understand it. I remember it very positive. |
|
@bbovenzi Thanks for the re-placement of the Note! This is a bit feeling like the proposal I had a longer time ago in #51764 with a bit improved folding. This improves for the proposed AIP-102 already 10% of what we need/want :-) - FYI @AutomationDev85 I think is better than before 3.3.0, but two nit to be considering from my view:
2026-06-11-notes-improvement-2026-06-12_00.11.35.mp4P.S.: @dheerajturaga I rememebr you also would LOVE to have this in 3.3.0? :-D |
|
Awesome! We were missing this feature from 2.x and very much liked it Glad it's back! 🥳 |
I don't understand this statement. You are describing a UX challange which we can resolve. But @bbovenzi mentioned a complexity challange around performance which is something else entirely. May I also point that some users disable dag versioning and even when disabled we don't have the marker. |
Yes, sorry. Bad English. Yes, I remember it was a "performance thing" and therefore (until now) it was not re-implemented. But am only 80% sure. |
|
I'll fix this all tonight @eladkal please open a separate GitHub issue. Changes to the grid is not in scope for this PR |
|
I had a chance to review the changes. Cool and much needed feature. Few notes:
I was thinking it would be better if it were a large note be displayed in a popup menu with an additional option to edit? or better yet provide a github comment style interface with |
c725dd9 to
2ef5afc
Compare
|
Ok. Reverted back to a modal but with a one line preview in the task and run header. But the modal has write/preview functionality. |
* Update note UX * Remove useEffects * code cleanup * Fix markdown * Revert back to modal, with preview * Add ellipsis for cutoff notes * Fix note editor showing unsaved text after cancel and stray scrollbar --------- Co-authored-by: pierrejeambrun <pierrejbrun@gmail.com>



Closes #52516
Upgrade our notes ux:
Was generative AI tooling used to co-author this PR?
Clause Sonnet 4.6
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.