Skip to content

Feat note modal#68362

Merged
pierrejeambrun merged 7 commits into
apache:mainfrom
astronomer:feat-note-accordion
Jun 16, 2026
Merged

Feat note modal#68362
pierrejeambrun merged 7 commits into
apache:mainfrom
astronomer:feat-note-accordion

Conversation

@bbovenzi

@bbovenzi bbovenzi commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Closes #52516

Upgrade our notes ux:

  • Single line note preview in the header. With a modal to see the full length. Supports links, and has a write/preview mode.
  • Add the note icon to dag run and task instance list pages to edit the note in a modal
  • Also removed the header border as it was clashing too much with our tabs and resize panel borders
Screenshot 2026-06-16 at 12 35 38 AM Screenshot 2026-06-16 at 12 35 26 AM Screenshot 2026-06-16 at 12 35 00 AM Screenshot 2026-06-10 at 4 37 07 PM
Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
    Clause Sonnet 4.6

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Jun 10, 2026
@bbovenzi bbovenzi marked this pull request as ready for review June 10, 2026 22:36
@bbovenzi bbovenzi added this to the Airflow 3.3.0 milestone Jun 10, 2026
@bbovenzi

Copy link
Copy Markdown
Contributor Author

cc: @eladkal @jscheffl

I am not sure I like the accordion but this one is at least more manageable.

@eladkal

eladkal commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

I expected to see an indication on the grid. Am I missing something?
Screenshot 2026-06-11 at 10 04 43

@pierrejeambrun pierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdown isn't renderd in the TI and table list on my end.

Screen.Recording.2026-06-11.at.17.07.35.mov

And also even in the task instance note, we're loosing some markdown capabilities, mapping is messed up, (spread operator + components is messing up the chakra mapping)

On main
Image

ON this branch ( see the note)
Image

@bbovenzi

Copy link
Copy Markdown
Contributor Author

@pierrejeambrun Updated. I was playing with custom headers, but it messed the rest up

@eladkal we removed that in 3.0 in order to show dag versioning in the grid view

@eladkal

eladkal commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@eladkal we removed that in 3.0 in order to show dag versioning in the grid view

I am aware we removed it but I don't understand where is the conflict? I don't see version indication on the dagrun grid

@jscheffl

Copy link
Copy Markdown
Contributor

@eladkal we removed that in 3.0 in order to show dag versioning in the grid view

I am aware we removed it but I don't understand where is the conflict? I don't see version indication on the dagrun grid

I think I remember the reasoning to remove it from Gris was (1) performance in the Grid query to fetch if note is existing (adds a join to note table) as (2) well as there was the feeling that the additional highlight "clutters" the view.

I tend to say was beneficial to have the markers but frakly speaking most users did not understand it. I remember it very positive.

@jscheffl

Copy link
Copy Markdown
Contributor

@bbovenzi Thanks for the re-placement of the Note! This is a bit feeling like the proposal I had a longer time ago in #51764 with a bit improved folding. This improves for the proposed AIP-102 already 10% of what we need/want :-) - FYI @AutomationDev85

I think is better than before 3.3.0, but two nit to be considering from my view:

  1. When navigating from a task to another (or to a run) the initial display of the note is always "folded to a single line" - this is good to save space but for a user it is not obvious that there it more than one line until he / she clicks. Is there any visual possible to inform that there is more than one line? Else in-experienced users might miss all from the second line and medium experienced users maybe only catch the first intro.

  2. (Also a problem in 3.0, 3.1 and 3.2): If a link is rendered in Markdown then is is well displayed, but clicking on it gets user to edit mode. You basically need to copy&paste a markdown link and open manually. Is there an option to have the z-index with priority that a click on a link is respecting the link and edit mode is only made when you click not on a link?

  3. I see there is no length validation in the new note. Notes (unfortunately) are limited to 1000 chars (maybe I need to contribute a feature allowing it to be more like a CLOB... 1000 chars as markdown might be a bit limiting...) - If you type more you just get an error that saving failed.

2026-06-11-notes-improvement-2026-06-12_00.11.35.mp4

P.S.: @dheerajturaga I rememebr you also would LOVE to have this in 3.3.0? :-D

@dheerajturaga

Copy link
Copy Markdown
Member

Awesome! We were missing this feature from 2.x and very much liked it

Glad it's back! 🥳

@eladkal

eladkal commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

I tend to say was beneficial to have the markers but frakly speaking most users did not understand it. I remember it very positive.

I don't understand this statement. You are describing a UX challange which we can resolve. But @bbovenzi mentioned a complexity challange around performance which is something else entirely.

May I also point that some users disable dag versioning and even when disabled we don't have the marker.

@jscheffl

jscheffl commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

I tend to say was beneficial to have the markers but frakly speaking most users did not understand it. I remember it very positive.

I don't understand this statement. You are describing a UX challange which we can resolve. But @bbovenzi mentioned a complexity challange around performance which is something else entirely.

May I also point that some users disable dag versioning and even when disabled we don't have the marker.

Yes, sorry. Bad English. Yes, I remember it was a "performance thing" and therefore (until now) it was not re-implemented. But am only 80% sure.

@bbovenzi

Copy link
Copy Markdown
Contributor Author

I'll fix this all tonight

@eladkal please open a separate GitHub issue. Changes to the grid is not in scope for this PR

@dheerajturaga

Copy link
Copy Markdown
Member

I had a chance to review the changes. Cool and much needed feature.

Few notes:

  • Clicking on the note immediately puts me in edit mode and one may accidentally modify the contents of the note. (
  • It is also not obvious at first glance that a note maybe present.

I was thinking it would be better if it were a large note be displayed in a popup menu with an additional option to edit? or better yet provide a github comment style interface with write and preview ? ( thinking out loud here, taking inspiration from the comment section on github)

@bbovenzi bbovenzi force-pushed the feat-note-accordion branch from c725dd9 to 2ef5afc Compare June 16, 2026 06:42
@bbovenzi bbovenzi changed the title Feat note accordion Feat note modal Jun 16, 2026
@bbovenzi

Copy link
Copy Markdown
Contributor Author

Ok. Reverted back to a modal but with a one line preview in the task and run header. But the modal has write/preview functionality.

@eladkal

eladkal commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

@eladkal please open a separate GitHub issue. Changes to the grid is not in scope for this PR

Ho wow. I completely read the issue wrong!
I read it as missing the note indication in the grid not as missing the note itself from the UI.
Followup opened by Eitan #68615

@pierrejeambrun pierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Tested and working as expected.

I just pushed a small adjustment commit for scrollbar and discard modal preview

@pierrejeambrun pierrejeambrun merged commit 18506de into apache:main Jun 16, 2026
85 checks passed
@pierrejeambrun pierrejeambrun deleted the feat-note-accordion branch June 16, 2026 10:25
RulerChen pushed a commit to RulerChen/airflow that referenced this pull request Jun 16, 2026
* Update note UX

* Remove useEffects

* code cleanup

* Fix markdown

* Revert back to modal, with preview

* Add ellipsis for cutoff notes

* Fix note editor showing unsaved text after cancel and stray scrollbar

---------

Co-authored-by: pierrejeambrun <pierrejbrun@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show dag run note in UI

5 participants