Cache bundle-to-team name lookups in dag processor manager#68730
Merged
Conversation
ferruzzi
requested review from
XD-DENG,
ashb,
ephraimbuddy and
jedcunningham
as code owners
June 18, 2026 19:42
o-nikolas
approved these changes
Jun 19, 2026
seanghaeli
approved these changes
Jun 19, 2026
seanghaeli
left a comment
Contributor
There was a problem hiding this comment.
Verified in breeze that the cache produces correct results, invalidation works, the n->1 query batching works, and a bundle can't be mapped to a second team
Contributor
|
@ferruzzi good to be merged? |
vincbeck
approved these changes
Jun 22, 2026
Contributor
Backport successfully created: v3-3-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
cetingokhan
pushed a commit
to cetingokhan/airflow
that referenced
this pull request
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to request by @o-nikolas in #68599 to add caching like we did in the scheduler.
Adding a
_bundle_name_to_team_namemap/cache and a_multi_teamflag (read once at construction, like the scheduler) onDagFileProcessorManageralso allowed me to move theif multi-teamcheck into the_get_team_names()and_get_team_name()helpers, simplifying the calling code.The cache/map is cleared inside the
_refresh_dag_bundles()method, which is the only time we can pick up new mappings anyway.Was generative AI tooling used to co-author this PR?
Generated-by: [Claude Opus 4.8] following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.