fix/task-group-branching: Allowing for relative paths to be branched to in a task group#68797
Draft
jroachgolf84 wants to merge 2 commits into
Draft
fix/task-group-branching: Allowing for relative paths to be branched to in a task group#68797jroachgolf84 wants to merge 2 commits into
jroachgolf84 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows for the proper resolution of relative paths when branching within a Task Group.
For example, if a Task Group
tghas a branching task and a taskaandb, returning"a"from the branching task will result inaexecuting andbgetting skipped. This is shown in the DAG/screenshot below.However, if there is both a top-level
aand anain the Task Group,awill be skipped in the Task Group.related: #65751
Testing
These changes were tested in two different ways; via unit tests, as well as E2E testing. To execute the unit tests added as part of this PR, the commands below can be run:
To test these changes E2E, the DAG below was used. To ensure the changes were correct, the behavior expected would be:
aintgexecutestg.cexecuteseinside oftgexecutes