Skip to content

Fix incompat of request.form with anyio 4.14.0 in aws auth manager #68834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amoghrajesh wants to merge 1 commit into from
Closed

Fix incompat of request.form with anyio 4.14.0 in aws auth manager #68834

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions providers/amazon/src/airflow/providers/amazon/aws/auth_manager/routes/login.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,12 @@
from __future__ import annotations

import logging
from typing import Any
from typing import TYPE_CHECKING, Any
from urllib.parse import urlparse

if TYPE_CHECKING:
from starlette.datastructures import FormData

import anyio
from fastapi import HTTPException, Request, status
from fastapi.responses import RedirectResponse
Expand Down Expand Up @@ -101,7 +104,7 @@ def login_callback(request: Request):
url = conf.get("api", "base_url", fallback="/")
token = get_auth_manager().generate_jwt(user)

form_data = anyio.from_thread.run(request.form)
form_data = anyio.from_thread.run(_fetch_form, request)
relay_state = form_data["RelayState"]

if relay_state == "login-redirect":
Expand Down Expand Up @@ -151,14 +154,18 @@ def _prepare_request(request: Request) -> dict:
"get_data": request.query_params,
"post_data": {},
}
form_data = anyio.from_thread.run(request.form)
form_data = anyio.from_thread.run(_fetch_form, request)
if "SAMLResponse" in form_data:
data["post_data"]["SAMLResponse"] = form_data["SAMLResponse"]
if "RelayState" in form_data:
data["post_data"]["RelayState"] = form_data["RelayState"]
return data


async def _fetch_form(request: Request) -> FormData:
return await request.form()


def _get_idp_data() -> dict:
saml_metadata_url = conf.get_mandatory_value(CONF_SECTION_NAME, CONF_SAML_METADATA_URL_KEY)
return OneLogin_Saml2_IdPMetadataParser.parse_remote(saml_metadata_url)
Loading