Deprecating poll_interval in ExternalTaskSensor for poke_interval - #68997
Conversation
|
Need to correct the titles to not use the conventional commit format. This does not seem to deprecate but instead outright remove |
jroachgolf84
changed the title
fix/issue-68990: Deprecating poll_interval in ExternalTaskSensor for poke_intervalpoll_interval in ExternalTaskSensor for poke_interval
|
@uranusjr and @phanikumv, would you mind re-reviewing this? Thanks! |
|
Same as the argument, we might also want to keep the old attribute for compatibility. It’s probably easiest to use a property that emits a deprecation warning on set/get. |
uranusjr
left a comment
uranusjr
left a comment
There was a problem hiding this comment.
Good enough. There are a couple of small nits that I would prefer fixing, but the PR won’t break without them either.
|
@uranusjr - happy to fix those nits. What are they, specifically? |
Happy to add this in! |
…rnal_task.py Co-authored-by: Phani Kumar <94376113+phanikumv@users.noreply.github.com>
@uranusjr - addressed in next commit. |
jroachgolf84
added
the
ready for maintainer review
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
One nit, otherwise LGTM
…ask_sensor.py Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
6 participants
Description
In the
ExternalTaskSensor, thepoll_intervalwas being instantiated and being used rather than thepoke_intervalparameter. Users passing inpoke_intervalwere not having that value respected (despitepoke_intervalbeing an inherited parameter fromBaseSensorOperator).This PR removes
poll_intervalfrom theExternalTaskSensorand ensures that the value set forpoke_intervalis respected.closes: #68990
Testing
Six new unit-tests were added as part of this PR. These unit tests ensure that:
poke_intervalis properly set upon initpoll_intervalis no longer supportedpoke_intervalpasses through to the Trigger when Operator is used in a deferrable fashionThese tests can be run with the following command: