Make Dag pause toggle update immediately on click - #69134
Merged
pierrejeambrun merged 2 commits intoJul 2, 2026
Merged
Conversation
The pause/unpause switch on the Dags list page waited for the dags list refetch to settle before flipping, which under fast interaction looked like the first clicks were dropped: clicking once on several rows left them all visually unchanged until enough subsequent clicks accumulated and the list eventually refetched. Apply React Query's optimistic update pattern: write the new is_paused into the dag detail and dags list caches on mutate, roll back if the server rejects, and invalidate the list on settle so filtered views (e.g. paused=true) drop the row that no longer matches the filter.
pierrejeambrun
marked this pull request as ready for review
June 30, 2026 13:15
pierrejeambrun
requested review from
bbovenzi,
choo121600,
guan404ming,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
June 30, 2026 13:15
Member
Author
BeforeScreen.Recording.2026-06-30.at.15.18.54.movAfterScreen.Recording.2026-06-30.at.15.15.57.mov |
The test seeded a single dags-list query and "verified" sibling invalidation with isFetching(...) >= 0, which is always true and asserted nothing. Seed a second list under a different filter and assert that both the prefix-keyed optimistic write and the on-settle invalidation reach it, so the test proves the cache update is not limited to the one seeded list variant.
phanikumv
approved these changes
Jul 1, 2026
1 task
potiuk
pushed a commit
that referenced
this pull request
Jul 30, 2026
vatsrahul1001
added a commit
that referenced
this pull request
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pause/unpause switch on the Dags list page waited for the dags-list refetch to settle before flipping. Under fast interaction this looked like the first clicks were dropped — clicking once on several rows left them all visually unchanged until enough subsequent clicks accumulated and the list eventually refetched. With a filter on
paused=true/false, the same delay meant a toggled row stayed in the visible list for a beat after the user changed its state instead of leaving the filtered view right away.Apply React Query's optimistic update pattern to
useTogglePause:onMutatewrites the newis_pausedinto the dag detail, dag, and all dags-list caches so the Switch reflects the new state on click instead of after the server round-trip.onErrorrolls each of those caches back to the pre-mutation snapshot if the server rejects, then surfaces the existing toaster.onSettledinvalidates the same query keys the previousonSuccessdid, so filtered list queries refetch and may move the row in or out of the visible page.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.7) following the guidelines