Test fix in main Celery worker tests leaking logging handler onto captured stdout - #69163
Merged
shahar1 merged 1 commit intoJun 30, 2026
Merged
Conversation
anishgirianish
requested review from
dheerajturaga and
hussein-awala
as code owners
June 30, 2026 05:39
anishgirianish
force-pushed
the
fix-celery-worker-test-logging-leak
branch
from
June 30, 2026 06:09
bbd85e7 to
eb08665
Compare
1 task
shahar1
approved these changes
Jun 30, 2026
karenbraganz
pushed a commit
to karenbraganz/airflow
that referenced
this pull request
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Celery worker CLI tests call the real
configure_logging(output=sys.stdout.buffer), which installs a logging handler on pytest's captured stdout. Once the capture buffer closes, every later test's setup/teardown logging fails withI/O operation on closed file, surfacing in the Postgres-backed Special test jobs (Pendulum2 / LatestBoto).This adds an autouse fixture stubbing
configure_logging(matching whatTestWorkerJsonLogsalready does per-test), so the handler is never installedWas generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.