Skip to content

Fix statsd_ipv6 config not enabling IPv6 sockets for the default StatsD client #69632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 3 commits into from
Jul 19, 2026
+13 −1
Merged

Fix statsd_ipv6 config not enabling IPv6 sockets for the default StatsD client #69632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c35a25c
Refactor get_statsd_logger to use keyword arguments for clarity and a…
ykuc Jul 8, 2026
80aef31
Merge branch 'main' into fix-statsd-ipv6-69451
ykuc Jul 10, 2026
32380ee
Merge branch 'main' into fix-statsd-ipv6-69451
ykuc Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion shared/observability/src/airflow_shared/observability/metrics/statsd_logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,12 @@ def get_statsd_logger(
statsd_influxdb_enabled: bool = False,
) -> SafeStatsdLogger:
"""Return logger for StatsD."""
statsd = stats_class(host, port, prefix, ipv6)
statsd = stats_class(
host=host,
port=port,
prefix=prefix,
ipv6=ipv6,
)

metric_tags_validator = PatternBlockListValidator(statsd_disabled_tags)
validator = get_validator(metrics_allow_list, metrics_block_list)
Expand Down
7 changes: 7 additions & 0 deletions shared/observability/tests/observability/metrics/test_stats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,13 @@ def get_statsd_logger_factory(
)


class TestGetStatsdLogger:
@mock.patch("statsd.StatsClient")
def test_passes_ipv6_as_keyword(self, mock_stats_client):
statsd_logger.get_statsd_logger(stats_class=mock_stats_client, ipv6=True)
assert mock_stats_client.call_args.kwargs["ipv6"] is True


class TestStats:
def setup_method(self):
self.statsd_client = Mock(spec=statsd.StatsClient)
Expand Down