Skip to content

Update system test to the latest api version of google-ads - #69865

Merged
potiuk merged 1 commit into
apache:mainfrom
VladaZakharova:update_google_ads_sys_test
Jul 31, 2026
Merged

Update system test to the latest api version of google-ads#69865
potiuk merged 1 commit into
apache:mainfrom
VladaZakharova:update_google_ads_sys_test

Conversation

@olegkachur-e

Copy link
Copy Markdown
Contributor
  • Update and run the dag to verify hook/operators compatibility.

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@olegkachur-e
olegkachur-e requested a review from shahar1 as a code owner July 14, 2026 10:41
@boring-cyborg boring-cyborg Bot added area:providers provider:google Google (including GCP) related issues labels Jul 14, 2026
@olegkachur-e
olegkachur-e force-pushed the update_google_ads_sys_test branch 2 times, most recently from 41b53c3 to 373f726 Compare July 14, 2026 13:43
@potiuk potiuk added the ready for maintainer review Set after triaging when all criteria pass. label Jul 15, 2026
@olegkachur-e
olegkachur-e force-pushed the update_google_ads_sys_test branch from 373f726 to 31b814c Compare July 20, 2026 10:15
- Update and run the dag to verify hook/operators compatibility.
@olegkachur-e
olegkachur-e force-pushed the update_google_ads_sys_test branch from 31b814c to fdb8bff Compare July 27, 2026 12:46
@VladaZakharova

Copy link
Copy Markdown
Contributor

hi there! Can we please check and merge this update of version? thanks :)
@shahar1

@potiuk potiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks — small and complete, which is the right shape for an API-version bump.

I checked the two things that usually go wrong with these:

Nothing is left on v21. The only remaining googleads.v21 reference in the provider is ads/hooks/ads.py, which this PR updates — so there's no half-migrated state afterwards.

There's no stale default hiding elsewhere. GoogleAdsHook.__init__ takes api_version: str | None = None and passes it straight to client.get_service(..., version=self.api_version), so when unset the google-ads library picks its own version. There's no hardcoded default constant that would have needed bumping alongside this.

The hook changes are TYPE_CHECKING-only, so no runtime behaviour moves; the real change is the system test targeting v24. With google-ads>=26.0.0 pinned, v24 is available, and CI passing static checks confirms the type paths resolve.


Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting

@potiuk
potiuk merged commit f588901 into apache:main Jul 31, 2026
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues ready for maintainer review Set after triaging when all criteria pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants