Update system test to the latest api version of google-ads - #69865
Conversation
41b53c3 to
373f726
Compare
373f726 to
31b814c
Compare
- Update and run the dag to verify hook/operators compatibility.
31b814c to
fdb8bff
Compare
|
hi there! Can we please check and merge this update of version? thanks :) |
potiuk
left a comment
There was a problem hiding this comment.
Thanks — small and complete, which is the right shape for an API-version bump.
I checked the two things that usually go wrong with these:
Nothing is left on v21. The only remaining googleads.v21 reference in the provider is ads/hooks/ads.py, which this PR updates — so there's no half-migrated state afterwards.
There's no stale default hiding elsewhere. GoogleAdsHook.__init__ takes api_version: str | None = None and passes it straight to client.get_service(..., version=self.api_version), so when unset the google-ads library picks its own version. There's no hardcoded default constant that would have needed bumping alongside this.
The hook changes are TYPE_CHECKING-only, so no runtime behaviour moves; the real change is the system test targeting v24. With google-ads>=26.0.0 pinned, v24 is available, and CI passing static checks confirms the type paths resolve.
Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.