[v3-3-test] Skip stored credentials when a connection test overrides host or port - #70010
Merged
Merged
Conversation
…apache#69957) The POST /connections/test endpoint restores an existing connection's stored credentials (password/extra) when the request sends the masked sentinel, so a saved connection can be tested without re-typing secrets. Connection configuration users have write-only access to those credentials and are not meant to view them; reusing them while the request points at a caller-supplied host or port applies them against a destination the caller chose rather than the connection's own, which is outside the intent of the retype-free test flow. Scope the credential reuse to requests that keep the stored connection's host and port. Follows the same hardening as apache#67620. (cherry picked from commit a6d87ba)
pierrejeambrun
requested review from
bugraoz93,
choo121600,
ephraimbuddy,
henry3260,
jason810496,
rawwar and
shubhamraj-git
as code owners
July 17, 2026 12:01
Contributor
|
Hi maintainer, this PR was merged without a milestone set.
|
vatsrahul1001
pushed a commit
that referenced
this pull request
Aug 5, 2026
…#69957) (#70010) The POST /connections/test endpoint restores an existing connection's stored credentials (password/extra) when the request sends the masked sentinel, so a saved connection can be tested without re-typing secrets. Connection configuration users have write-only access to those credentials and are not meant to view them; reusing them while the request points at a caller-supplied host or port applies them against a destination the caller chose rather than the connection's own, which is outside the intent of the retype-free test flow. Scope the credential reuse to requests that keep the stored connection's host and port. Follows the same hardening as #67620. (cherry picked from commit a6d87ba)
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #69957 to
v3-3-test.Cherry-picked from a6d87ba.
Conflict resolution (
connections.py): the cherry-pick pulled in theget_team_name/is_authorized_connection(GET)authorization scaffolding from #67620, which is not onv3-3-test. Only #69957's own change was applied — skipping stored credentials when the request overrides the stored connection's host or port — adapted to thev3-3-testcode structure (the inlinetry/exceptwas converted toexisting_conn: Connection | None+if/else, mirroring the post-#69957 shape onmainminus the #67620 dependency). The test file applied cleanly, and all connection-test unit tests pass.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines