Fix regression: Mark Task Instance As no longer defaults to Downstream#70048
Closed
luisglft wants to merge 4 commits into
Closed
Fix regression: Mark Task Instance As no longer defaults to Downstream#70048luisglft wants to merge 4 commits into
luisglft wants to merge 4 commits into
Conversation
…ault PR apache#52130 added defaultValues={["downstream"]} to the shared SegmentedControl in both ClearTaskInstanceDialog and MarkTaskInstanceAsDialog. For the Clear dialog this only fixed a display bug, since its own state already defaulted to ["downstream"]. For MarkTaskInstanceAsDialog, however, the state previously started empty (useState<Array<string>>([])) with no defaultValues on the control, so nothing was preselected. Adding defaultValues={["downstream"]} here means "Downstream" is now selected by default when marking a task instance as success/failed, which sets state on downstream task instances too -- without executing them, since mark-as only patches state and never runs anything. Anyone who confirms without noticing and deselecting "Downstream" silently short-circuits the rest of the DAG. Remove the defaultValues prop from this dialog's SegmentedControl to restore the pre-apache#52130 behavior of nothing selected by default, leaving ClearTaskInstanceDialog untouched since its default is correct.
luisglft
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
July 17, 2026 18:59
potiuk
added
the
ready for maintainer review
Author
|
Common use case for mark a task as success is to allow downstream tasks to run without getting blocked by that task, so we want to have downstream tasks running instead of mark as success. This was the default behavior in Airflow 2 |
Contributor
|
Duplicate of #67763 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#52130 added
defaultValues={["downstream"]}to the sharedSegmentedControl(Past/Future/Upstream/Downstream) used by bothClearTaskInstanceDialogandMarkTaskInstanceAsDialog.useState(["downstream"])before Set downstream option to default on task instance clear #52130 — the PR only fixed a display bug where the button looked unselected despite downstream already being included in the clear request.This PR removes the
defaultValues={["downstream"]}prop fromMarkTaskInstanceAsDialogonly, restoring the pre-#52130 opt-in default.ClearTaskInstanceDialogis untouched.Test plan