[v3-3-test] Discount CI image-build time from duration-trend alerts (#69789)#70102
Merged
Conversation
…69789) * Discount CI image-build time from duration-trend alerts The CI duration monitor folded the "Prepare breeze & CI image" step into each job's total. That step occasionally balloons on a one-off cache miss (a full image rebuild instead of a cached pull), which repeatedly flagged unrelated jobs as regressed — e.g. a Non-DB core job reported +190% driven almost entirely by an 18m image build, while its actual test time was flat. Image-build time is now excluded from the run and per-job durations used for the trend, and the image build is watched on its own: it is only reported when it has stayed slow for more than two days, so a transient rebuild spike no longer produces a false alert. * Apply naming nits: prefix duration helpers with calculate_ Rename work_duration -> calculate_work_duration, run_image_build_seconds -> calculate_image_build_seconds, adjusted_run_duration -> calculate_adjusted_run_duration for a consistent calculate_ prefix on the duration-computing helpers. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- (cherry picked from commit 582076c) Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
1 task
potiuk
marked this pull request as ready for review
July 19, 2026 20:32
potiuk
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl and
potiuk
as code owners
July 19, 2026 20:32
potiuk
approved these changes
Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI duration monitor folded the "Prepare breeze & CI image" step into
each job's total. That step occasionally balloons on a one-off cache miss
(a full image rebuild instead of a cached pull), which repeatedly flagged
unrelated jobs as regressed — e.g. a Non-DB core job reported +190% driven
almost entirely by an 18m image build, while its actual test time was flat.
Image-build time is now excluded from the run and per-job durations used
for the trend, and the image build is watched on its own: it is only
reported when it has stayed slow for more than two days, so a transient
rebuild spike no longer produces a false alert.
Rename work_duration -> calculate_work_duration,
run_image_build_seconds -> calculate_image_build_seconds,
adjusted_run_duration -> calculate_adjusted_run_duration for a
consistent calculate_ prefix on the duration-computing helpers.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
(cherry picked from commit 582076c)
Co-authored-by: Jarek Potiuk jarek@potiuk.com
Co-authored-by: Claude Opus 4.8 noreply@anthropic.com