[v3-3-test] Clarify AssetPartitionDagRun provisional-run docstring (#69982)#70104
Merged
Conversation
…69982) The previous wording ("we should not allow more than one like this") did not state the actual invariant. Make explicit that rows are never deleted — so multiple records per target_dag_id/partition_key are expected — and that the constraint is specifically at most one row with a null created_dag_run_id, which the _lock_asset_model mutex enforces. (cherry picked from commit 6e411d8) Co-authored-by: Daniel Standish <15932138+dstandish@users.noreply.github.com>
1 task
potiuk
marked this pull request as ready for review
July 19, 2026 22:00
Contributor
Author
|
Hi maintainer, this PR was merged without a milestone set.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous wording ("we should not allow more than one like this") did not
state the actual invariant. Make explicit that rows are never deleted — so
multiple records per target_dag_id/partition_key are expected — and that the
constraint is specifically at most one row with a null created_dag_run_id,
which the _lock_asset_model mutex enforces.
(cherry picked from commit 6e411d8)
Co-authored-by: Daniel Standish 15932138+dstandish@users.noreply.github.com