Go SDK: Propagate OTel context to Go SDK tasks#70166
Open
viiccwen wants to merge 1 commit into
Open
Conversation
Go tasks currently lose their remote parent at the bundle boundary, which breaks trace continuity and prevents task instrumentation from joining the scheduler-created trace. Signed-off-by: viiccwen <vicwen@apache.org>
Contributor
Author
|
cc @jason810496, @henry3260. 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #70165.
Go SDK tasks executed through the bundle gRPC path currently don't have the task instance's OpenTelemetry context carrier. This breaks trace continuity at the Go task boundary even though the protobuf schema already provides an
otel_contextfield.This change:
context.Context, allowing task instrumentation and downstream API calls to inherit the remote parent.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.