Fix CohereEmbeddingOperator input_text normalization before rendering - #70325
Merged
shahar1 merged 2 commits intoJul 24, 2026
Merged
Conversation
input_text is a template field, rendered after __init__ runs. Wrapping a single string into a list in the constructor acts on the un-rendered Jinja expression, so a templated input_text is mis-wrapped before it resolves. Move the normalization into execute() so it runs on the rendered value.
MannXo
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl and
potiuk
as code owners
July 23, 2026 20:30
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
78 tasks
shahar1
approved these changes
Jul 24, 2026
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the single-string normalization of
input_textfrom__init__intoexecute().input_textis a template field, so it is rendered after the constructor runs. Wrapping a plain string into a list in__init__acts on the un-rendered Jinja expression, so a templatedinput_text(for example one that resolves to a list under native rendering) is normalized before it is ever rendered. Doing it inexecute()operates on the rendered value.Part of the template-field constructor burn-down; removes the
CohereEmbeddingOperatorentry fromscripts/ci/prek/validate_operators_init_exemptions.txtin the same PR, as the hook requires.related: #70296
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines