Validate DatabricksSQLStatementsSensor statement fields after rendering - #70340
Merged
Conversation
statement and statement_id are template fields, rendered after __init__ runs. The constructor enforced their mutual exclusivity and presence there, acting on the un-rendered Jinja expressions. Move both checks into execute(); the warehouse_id check reads no template field and stays in __init__. related: apache#70296 Signed-off-by: 1fanwang <1fannnw@gmail.com>
1fanwang
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl and
potiuk
as code owners
July 23, 2026 22:15
boring-cyborg
Bot
added
area:dev-tools
area:providers
backport-to-v3-3-test
1fanwang
marked this pull request as draft
July 24, 2026 05:47
Signed-off-by: 1fanwang <1fannnw@gmail.com>
1fanwang
marked this pull request as ready for review
July 24, 2026 06:23
shahar1
reviewed
Jul 24, 2026
shahar1
left a comment
shahar1
left a comment
Contributor
There was a problem hiding this comment.
Could you please resolve conflicts? (failed test seem transient)
…sensor-init Signed-off-by: 1fanwang <1fannnw@gmail.com> # Conflicts: # scripts/ci/prek/validate_operators_init_exemptions.txt
Signed-off-by: 1fanwang <1fannnw@gmail.com>
shahar1
approved these changes
Jul 24, 2026
7 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
statementandstatement_idare template fields, so they are rendered after__init__runs. The constructor enforced their mutual exclusivity and presence there, acting on the un-rendered Jinja expressions — so a templatedstatement_idcouldn't resolve before the check ran. Move both checks intoexecute(). Thewarehouse_idcheck reads no template field and stays in__init__.related: #70296
Testing Done
New parametrized
test_statement_combination_validated_at_executecovers both branches (both provided / neither provided) and asserts theAirflowExceptionnow surfaces fromexecute(). Both fail on the pre-fix source (the constructor raises first) and pass after.test_databricks.py(sensors): 22 passed.validate_operators_init.pyexits 0; theraise AirflowExceptioncount is unchanged.Was generative AI tooling used to co-author this PR?
Generated-by: GitHub Copilot CLI following the guidelines