Skip to content

Fail AzureVirtualMachineStateSensor fast on an invalid target_state #70372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shahar1 merged 1 commit into from
Jul 24, 2026
Merged

Fail AzureVirtualMachineStateSensor fast on an invalid target_state #70372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions providers/microsoft/azure/src/airflow/providers/microsoft/azure/sensors/compute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,6 @@ def __init__(
self.deferrable = deferrable

def poke(self, context: Context) -> bool:
# target_state is a template field; validate the rendered value here, not in __init__.
if self.target_state not in self.VALID_STATES:
raise ValueError(
f"Invalid target_state: {self.target_state}. Must be one of {sorted(self.VALID_STATES)}"
)
hook = AzureComputeHook(azure_conn_id=self.azure_conn_id)
current_state = hook.get_power_state(self.resource_group_name, self.vm_name)
self.log.info("VM %s power state: %s", self.vm_name, current_state)
Expand All @@ -85,6 +80,10 @@ def execute(self, context: Context) -> None:
In deferrable mode, the polling is deferred to the triggerer. Otherwise
the sensor waits synchronously.
"""
if self.target_state not in self.VALID_STATES:
raise ValueError(
f"Invalid target_state: {self.target_state}. Must be one of {sorted(self.VALID_STATES)}"
)
if not self.deferrable:
super().execute(context=context)
else:
Expand Down
8 changes: 6 additions & 2 deletions providers/microsoft/azure/tests/unit/microsoft/azure/sensors/test_compute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,15 +43,19 @@ def test_init(self):
assert sensor.target_state == "running"
assert sensor.azure_conn_id == CONN_ID

def test_invalid_target_state_rejected_at_poke(self):
@pytest.mark.parametrize("deferrable", [False, True])
def test_invalid_target_state_rejected_at_execute(self, deferrable):
sensor = AzureVirtualMachineStateSensor(
task_id="sense_vm",
resource_group_name=RESOURCE_GROUP,
vm_name=VM_NAME,
target_state="invalid_state",
deferrable=deferrable,
silent_fail=True,
timeout=0,
)
with pytest.raises(ValueError, match="Invalid target_state"):
sensor.poke(context=None)
sensor.execute(context=None)

def test_templated_target_state_constructs(self):
sensor = AzureVirtualMachineStateSensor(
Expand Down