Skip to content

Move AwsToAwsBaseOperator fallback out of init #70445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincbeck merged 1 commit into from
Jul 27, 2026
Merged

Move AwsToAwsBaseOperator fallback out of init #70445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions providers/amazon/src/airflow/providers/amazon/aws/transfers/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,13 @@ def __init__(
super().__init__(**kwargs)
self.source_aws_conn_id = source_aws_conn_id
self.dest_aws_conn_id = dest_aws_conn_id
self.source_aws_conn_id = source_aws_conn_id
if is_arg_set(dest_aws_conn_id):
self.dest_aws_conn_id = dest_aws_conn_id
else:
self.dest_aws_conn_id = self.source_aws_conn_id

@property
def dest_aws_conn_id(self) -> str | None:
if is_arg_set(self._dest_aws_conn_id):
return self._dest_aws_conn_id
return self.source_aws_conn_id

@dest_aws_conn_id.setter
def dest_aws_conn_id(self, value: str | None | ArgNotSet) -> None:
self._dest_aws_conn_id = value
17 changes: 17 additions & 0 deletions providers/amazon/tests/unit/amazon/aws/transfers/test_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,23 @@ def setup_method(self):
args = {"owner": "airflow", "start_date": DEFAULT_DATE}
self.dag = DAG("test_dag_id", schedule=None, default_args=args)

def test_dest_aws_conn_id_defaults_to_source_aws_conn_id(self):
operator = AwsToAwsBaseOperator(
task_id="dynamodb_to_s3_test_default_dest",
source_aws_conn_id="source_conn",
)

assert operator.dest_aws_conn_id == "source_conn"

def test_dest_aws_conn_id_allows_explicit_none(self):
operator = AwsToAwsBaseOperator(
task_id="dynamodb_to_s3_test_dest_none",
source_aws_conn_id="source_conn",
dest_aws_conn_id=None,
)

assert operator.dest_aws_conn_id is None

@pytest.mark.db_test
def test_render_template(self, session, clean_dags_dagruns_and_dagbundles, testing_dag_bundle):
operator = AwsToAwsBaseOperator(
Expand Down
1 change: 0 additions & 1 deletion scripts/ci/prek/validate_operators_init_exemptions.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ providers/amazon/src/airflow/providers/amazon/aws/operators/s3.py::S3DeleteObjec
providers/amazon/src/airflow/providers/amazon/aws/operators/sagemaker.py::SageMakerCreateNotebookOperator
providers/amazon/src/airflow/providers/amazon/aws/operators/sagemaker.py::SageMakerProcessingOperator
providers/amazon/src/airflow/providers/amazon/aws/operators/step_function.py::StepFunctionStartExecutionOperator
providers/amazon/src/airflow/providers/amazon/aws/transfers/base.py::AwsToAwsBaseOperator
providers/amazon/src/airflow/providers/amazon/aws/transfers/gcs_to_s3.py::GCSToS3Operator
providers/amazon/src/airflow/providers/amazon/aws/transfers/s3_to_redshift.py::S3ToRedshiftOperator
providers/anthropic/src/airflow/providers/anthropic/operators/agent.py::AnthropicAgentSessionOperator
Expand Down