Resolve AwsToAwsBaseOperator destination connection after template rendering - #70487
Closed
mitre88 wants to merge 1 commit into
Closed
Resolve AwsToAwsBaseOperator destination connection after template rendering#70487mitre88 wants to merge 1 commit into
mitre88 wants to merge 1 commit into
Conversation
…ndering source_aws_conn_id and dest_aws_conn_id are template fields, but the dest-falls-back-to-source resolution ran in __init__, before Jinja rendering — a templated source_aws_conn_id was copied un-rendered into dest_aws_conn_id at Dag parse time. Resolve at use time instead.
mitre88
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl,
o-nikolas and
potiuk
as code owners
July 27, 2026 00:21
boring-cyborg
Bot
added
area:dev-tools
area:providers
backport-to-v3-3-test
uranusjr
approved these changes
Jul 27, 2026
vincbeck
approved these changes
Jul 27, 2026
Contributor
Author
|
Closing — #70445 merged an equivalent fix for this class (a Drafted-by: Claude Code (Fable 5) (no human review before posting) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
source_aws_conn_idanddest_aws_conn_idare template fields ofAwsToAwsBaseOperator, but the fallback ("dest not set → use source") was resolved in__init__, before Jinja rendering.__init__now keeps plain assignments (also dropping a duplicatedsource_aws_conn_idassignment) and the fallback lives in aresolved_dest_aws_conn_idproperty, whichDynamoDBToS3Operator(the only in-repo consumer) reads at execute time. Removes the class from the exemption list.related: #70296
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Fable 5) following the guidelines