Skip to content

Validate GCSToLocalFilesystemOperator arguments after template rendering #70489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mitre88 wants to merge 1 commit into from
Closed

Validate GCSToLocalFilesystemOperator arguments after template rendering #70489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions providers/google/src/airflow/providers/google/cloud/transfers/gcs_to_local.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,6 @@ def __init__(
file_encoding: str = "utf-8",
**kwargs,
) -> None:
if filename is not None and store_to_xcom_key is not None:
raise ValueError("Either filename or store_to_xcom_key can be set")
super().__init__(**kwargs)
self.bucket = bucket
self.filename = filename
Expand All @@ -100,6 +98,8 @@ def __init__(
self.file_encoding = file_encoding

def execute(self, context: Context):
if self.filename is not None and self.store_to_xcom_key is not None:
raise ValueError("Either filename or store_to_xcom_key can be set")
self.log.info("Executing download: %s, %s, %s", self.bucket, self.object_name, self.filename)
hook = GCSHook(
gcp_conn_id=self.gcp_conn_id,
Expand Down
13 changes: 13 additions & 0 deletions providers/google/tests/unit/google/cloud/transfers/test_gcs_to_local.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,19 @@ def test_execute(self, mock_hook):
bucket_name=TEST_BUCKET, object_name=TEST_OBJECT, filename=LOCAL_FILE_PATH
)

@mock.patch("airflow.providers.google.cloud.transfers.gcs_to_local.GCSHook")
def test_filename_and_xcom_key_fails_at_execute_time(self, mock_hook):
operator = GCSToLocalFilesystemOperator(
task_id=TASK_ID,
bucket=TEST_BUCKET,
object_name=TEST_OBJECT,
filename=LOCAL_FILE_PATH,
store_to_xcom_key=XCOM_KEY,
)
with pytest.raises(ValueError, match="Either filename or store_to_xcom_key can be set"):
operator.execute(None)
mock_hook.return_value.download.assert_not_called()

@mock.patch("airflow.providers.google.cloud.transfers.gcs_to_local.GCSHook")
def test_size_lt_max_xcom_size(self, mock_hook):
operator = GCSToLocalFilesystemOperator(
Expand Down
1 change: 0 additions & 1 deletion scripts/ci/prek/validate_operators_init_exemptions.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ providers/google/src/airflow/providers/google/cloud/transfers/azure_fileshare_to
providers/google/src/airflow/providers/google/cloud/transfers/bigquery_to_mssql.py::BigQueryToMsSqlOperator
providers/google/src/airflow/providers/google/cloud/transfers/gcs_to_bigquery.py::GCSToBigQueryOperator
providers/google/src/airflow/providers/google/cloud/transfers/gcs_to_gcs.py::GCSToGCSOperator
providers/google/src/airflow/providers/google/cloud/transfers/gcs_to_local.py::GCSToLocalFilesystemOperator
providers/google/src/airflow/providers/google/marketing_platform/operators/campaign_manager.py::GoogleCampaignManagerDeleteReportOperator
providers/microsoft/azure/src/airflow/providers/microsoft/azure/transfers/gcs_to_wasb.py::GCSToAzureBlobStorageOperator
providers/microsoft/azure/src/airflow/providers/microsoft/azure/transfers/oracle_to_azure_data_lake.py::OracleToAzureDataLakeOperator
Expand Down