Skip to content

Use ValueError when no ArangoDB collection operation is specified #70539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Jul 31, 2026
+14 −3
Merged

Use ValueError when no ArangoDB collection operation is specified #70539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion generated/known_airflow_exceptions.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,6 @@ providers/apache/pinot/src/airflow/providers/apache/pinot/hooks/pinot.py::1
providers/apache/spark/src/airflow/providers/apache/spark/hooks/spark_sql.py::2
providers/apache/spark/src/airflow/providers/apache/spark/hooks/spark_submit.py::10
providers/arangodb/src/airflow/providers/arangodb/hooks/arangodb.py::9
providers/arangodb/src/airflow/providers/arangodb/operators/arangodb.py::1
providers/atlassian/jira/src/airflow/providers/atlassian/jira/hooks/jira.py::1
providers/celery/src/airflow/providers/celery/executors/celery_executor_utils.py::2
providers/celery/src/airflow/providers/celery/executors/default_celery.py::2
Expand Down
4 changes: 2 additions & 2 deletions providers/arangodb/src/airflow/providers/arangodb/operators/arangodb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
from typing import TYPE_CHECKING, Any

from airflow.providers.arangodb.hooks.arangodb import ArangoDBHook
from airflow.providers.common.compat.sdk import AirflowException, BaseOperator
from airflow.providers.common.compat.sdk import BaseOperator

if TYPE_CHECKING:
from airflow.providers.common.compat.sdk import Context
Expand Down Expand Up @@ -112,7 +112,7 @@ def execute(self, context: Context):
self.delete_collection,
]
):
raise AirflowException("At least one operation must be specified.")
raise ValueError("At least one operation must be specified.")

if self.documents_to_insert:
self.log.info(
Expand Down
12 changes: 12 additions & 0 deletions providers/arangodb/tests/unit/arangodb/operators/test_arangodb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@

from unittest import mock

import pytest

from airflow.providers.arangodb.operators.arangodb import AQLOperator, ArangoDBCollectionOperator


Expand Down Expand Up @@ -47,3 +49,13 @@ def test_insert_documents(self, mock_hook):
op.execute(mock.MagicMock())
mock_hook.assert_called_once_with(arangodb_conn_id="arangodb_default")
mock_hook.return_value.insert_documents.assert_called_once_with("students", documents_to_insert)

@mock.patch("airflow.providers.arangodb.operators.arangodb.ArangoDBHook")
def test_no_operation_fails(self, mock_hook):
op = ArangoDBCollectionOperator(
task_id="noop_task",
collection_name="students",
)
with pytest.raises(ValueError, match="At least one operation must be specified."):
op.execute(mock.MagicMock())
mock_hook.return_value.insert_documents.assert_not_called()